[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] public/io: xs_wire: Allow Xenstore to report EPERM
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Jun 2022 08:57:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4DBhxCmD8w9E0mWextSw33DyRZn7iIh2zAv1//e6U30=; b=oYzJ222AcK+6NlZJQgKWGAwwsWdKhS+geswlwuE7cVjRFnv38UH4QzOfstrmxDJ/M2aQlF2Fv5VRNMxVn5B2yrSKLdhOqoz7eFnlf0QPgUDq1f4fA9tsoJZSeoUkfuDpA/5je3U2TfGjTKuESasnyZtE9ELrVy/XgVXXYzHCSNuLc1fjBtL62k/FrVZAnia5vMydVwlwAJHl99FqstslKHqWparTJAcU9FzJXuJMhwBffdiMoMqGjYtp+JxSXQ8SfpnMduYKmJZrLU4VovvapCVXdKZHjMVC6P8Z0UR3xIlHYjiyski1LX9xSzbk955uqxb2A3C0Mv9H+w1iGN1NFg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jeGXKaiH3IFBEFxJjV2E3ij3WQdyXFdM90/pvzR4bLTbUUdhAcfUdKcWobVsJ6ahYD5JK/HG4fvZ+rKNWnVJPU//WDK1orBgVzWqBTFP/3l/PoDYZdQ7SbQWFLfRECJ3zAfuV4bxBt0ELPYo0VgAD0QiyD9KFoaI0O9kblqhtz95jMDWPC1ytHlQQvCUzTKTuIBgUbl2KZrv6n1joeq3I0oVvhwB7gBn+EwoXzvSJtPMk1JASXAQT8i5vuV0XnNGZlF75mgh6ZaFW1vz2YxN0xtGvgDy3ShgVE+HwJY6gvhSFzN8biMFjFBH1GHtYu3ukYS0OImJ/wMrxIHXtIboJg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 27 Jun 2022 06:57:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.06.2022 18:51, Julien Grall wrote:
> --- a/xen/include/public/io/xs_wire.h
> +++ b/xen/include/public/io/xs_wire.h
> @@ -76,6 +76,7 @@ static struct xsd_errors xsd_errors[]
> __attribute__((unused))
> #endif
> = {
> + XSD_ERROR(EPERM),
> XSD_ERROR(EINVAL),
> XSD_ERROR(EACCES),
> XSD_ERROR(EEXIST),
Inserting ahead of EINVAL looks to break xenstored_core.c:send_error(),
which - legitimately or not - assumes EINVAL to be first.
Jan
|
