[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] xen/common: vm_event: Fix MISRA C 2012 Rule 8.7 violation
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Jun 2022 09:11:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+LGdPoDcQdqBt0fQskbltJ7wo0Fk5ytPBxVpSC/PZw=; b=gjGjR5vCyqzWq7cQ0mqm0QPdWq9EW50K+VjPNk/TboEy2I+5cA5/WdBnEh6gb6OO02uiHjFYcUzLAV5SABu0Ccg7N9/r2ZsbQAUz9K8dMW0idrN6vOR9y0ZqDZN3daa051hvBwGTfkkLBqng9UTwgKZ4Ew1ucCGis2pjCRHINWfG/lAfdJo6xu4HzW48CX6VnjvrAG2rkdvJcu4WVW0Bt1U69d1rr6iKhBH/tnrExIff0dSnFyHy5B4xDHgHWcDKbSqMEPx3we0Opcp2S2l5Isr6Pde7umgxaDEYMT5H3w7keOs4fIymabsmxTrXFFmpdJN20s9pjsfSTikz9pXN1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VPt0tg1B5T41LBGlQF2wo2WT92veTkZnweJ8pX88vzkqMNW7+NxlCmfUmHS5Pw4fsL5+6suJvhRKBEBU2QDAF0Zreb7hiJOweja81KlgoovjJ9M9LKl/MPsVu4zq0sC7NziouocvWt9M2n1PWpr5dVBt+7hOJMwpRBobH89rZn6txUZGqsq4S/g3HMc3HeM95YbOYjzVTrRVkCn8jsGDbRVFly7kWWaDHK91fEFBegcP35ekLp2IqaKDS/NsUatA/zBHoFoCr8w0WD+7R3DPsI1PJave6QpSv+DGyeWltGoqSr17hIshMHwCkegy7Hxi6kNLl2goBbkpwik86tVZ9w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 27 Jun 2022 07:11:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.06.2022 23:11, Xenia Ragiadakou wrote:
> The function vm_event_wake() is referenced only in vm_event.c.
> Change the linkage of the function from external to internal by adding
> the storage-class specifier static to the function definition.
>
> This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation
> warning.
Actually also for patch 1 - this is slightly confusing, as the title
talks about 8.7. At first I suspected a typo. May I suggest to add
"also" (which I think could be easily done while committing)?
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
