[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] xen/drivers: iommu: Fix MISRA C 2012 Rule 8.7 violation


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 27 Jun 2022 09:12:33 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZcZW2e5NNjilZudK7OJVh1EOzJh1lbAIyLkW9aNErik=; b=cHCS8ymKe1y34eWp5nOgyIYWMo9Dw6zKPoX1+qCCoEdAQp1SMHWVR+1KIHbC5DhPOF3NtQ+m8Xj8KRHh3vjZyMf+ptvCPxuzHk2/CIcNboVWxLufpfi54VMk8z1y05ZZ+9CEFiYrcSZWujHix4Ff8j60HV1efElusQVi2Hw3KoQ9VOYcoMVyxYB/x51PLho/Dvx/QrVyT1W1IEeMdnhRhO+tNs6N9FmDGQAS49VKoThU+Twq6K9m4FL85Zyca5Sk27dZ7eLIqL5yX0V81iZ1p9HNo7ynLghgIqSkTFR9TojLXUjtllShDiUYga9P62VhXFNkFjuO3Gk5Uw1mTKNcug==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TIIWIfAyypZg2U+2pEksFV9mIOeTEEx7OpAGzmDdEDXKCUY3QAlNsukVrAkr+cYJE3Vu2dJxwghC7Tj5H+I1+M+WU8ldX521VYkt0kTqbZNA/SaxhWtzSc/xYne2uyEeFKKdO1Liu775en2h4/j+xbDl4iLfKv5kF6hlmm3YrDyxsNJ+sgH+lOJO5dwlX6DRkg9xFyCOAChzpgb9LWauWaXr4Yifyn3wDP4AkOHyAC9HAO7UK6AseAZK6iONFThsTZYh1KWMSuko8oEivw6Rpv/8i/x9wxbjezKPEhcJFGh++6ivndntCJqFUQINFTHKXnCQt/FZlaB0hDTE+58ESA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 27 Jun 2022 07:12:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.06.2022 23:11, Xenia Ragiadakou wrote:
> The variable iommu_crash_disable is referenced only in one translation unit.
> Change its linkage from external to internal by adding the storage-class
> specifier static to its definition.
> 
> This patch aims to resolve indirectly a MISRA C 2012 Rule 8.4 violation 
> warning.
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
(with the same remark as on patch 2)



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.