[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] console/serial: bump buffer from 16K to 32K
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 29 Jun 2022 17:23:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qotMkl5OwEnIimmwqNF0LmAhZev6AVNiaN6J2nWxWMw=; b=oRZ6F+YXqp51+arjMcIhkiRoCV7lK09/DOKpzKN4hnjGq6amA0s+6NXwaF9iATqNbWzH37SvlvTsCPOd2NB4QRzJXFBgsB836gPRsgdNlX1z72MFA1gNzM6Uow1Gm1V6Q6H58edEAM/tKdl3SU+BTUgg34ADtrUxX1Uyx8zbBCAZKvQgBRYV46P6p0ldYIhuQFypt/cZX+LfMrKek6Lc/38R68sFIl2XrrptXEiRMYwcRqc2MWwPwumkMMK5RYka91b+FmAdcNhQaqsojlMYHoZYopE8c2wxQl/n2NsSzfcyI4fKMOuPcrtU5EJ5tWXoMNXJOQoDMwL2yVsYNfL8nA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oavj1XIaD3FQyLpcSyNo8xmU0j7+4nBhHiz8JB5OA5zaojGwR84hAkwIHgt4dNsUTbLcna1Zh3+pO8LRdatGm6Qw/HQMaJB1fUorrSfmk6HpuD/BmiGCakXR4w8alFNwEizapQCM+4MH3GeVSb0YpeisDqUNqrO4Em439Nl0zlqBKpxzoqYcioYDBdLWaCfsHI/8t5QYHXFnPTPd5lo0DYTBlKPnn5Xv59Yp3PBqFObk1j/Jt5Izoh+fngroTWpuCE5IIgH4y4Z7nykIuts/+HSg4whSWwqNhYm9if1NR+3u1/nyJHUcD00gimlM170NFc3f9RYcvvIDhDnp0k5arw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 29 Jun 2022 15:23:18 +0000
- Ironport-data: A9a23:QjKLIK6v9b2t8UK/dg5uTAxRtCfGchMFZxGqfqrLsTDasY5as4F+v mZMDDvUPPzbYjGmeowgOo/lpkwAu5OHnNc3HAVr/H9nHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw03qPp8Zj2tQy2YbjUlvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSJEDsjY47gnNgSEAICNCB1F/J9qa3IdC3XXcy7lyUqclPK6tA3VQQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiVo4YHh1/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IE9gPK9PVui4TV5DJf1JjiYITWQcWlQJRy2X+Eu VvtvGusV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVXQC8oXOClg4RXZxXCeJSwBqW1qPe7gKdB24FZj1MctorsIkxXzNC/ kCNt8PkA3poqrL9dJ6G3rKdrDf3NS1LK2YHPHYAVVFcvIKlp5wvhBXSSNolCLSyktD+BTD3x XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjv9hu+lTOZJv7CV1GU=
- Ironport-hdrordr: A9a23:539hBqB1jAxYBrjlHehJsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80lKQFmLX5WI3PYOCIgguVxe1ZnOjfKnjbalbDH41mpN tdmspFebrN5DFB5K6VgTVQUexQpuVvmJrY+Ns2pE0dKT2CBZsQjTuQXW2gYzdLrUR9dO0EPa vZwvACiyureHwRYMj+Ln4ZX9Lbr9mOsJ79exYJCzMu9QHL1FqTmffHOind+i1bfyJEwL8k/2 SAuwvl5p+7u/X+7hPHzWfc47lfhdOk4NpeA86njNQTN1zX+3CVTbUkf4fHkCE+oemp5lpvuN 7Qoy04N8A20H/VdnHdm2qe5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe 929lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQlo+a87bW3HAb0cYa dT5Jm23ocWTbraVQGTgoBX+q3hYpxpdS32AnTruaSuoktrdT5CvgglLfck7wk9HaIGOuZ5Dt v/Q9VVfZF1P7orhPFGdZM8aPryLFDxajTxF0/XCWjbNcg8SgLwQtjMkf0I2N0=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jun 23, 2022 at 03:32:30PM +0200, Jan Beulich wrote:
> On 23.06.2022 11:08, Roger Pau Monne wrote:
> > Testing on a Kaby Lake box with 8 CPUs leads to the serial buffer
> > being filled halfway during dom0 boot, and thus a non-trivial chunk of
> > Linux boot messages are dropped.
> >
> > Increasing the buffer to 32K does fix the issue and Linux boot
> > messages are no longer dropped. There's no justification either on
> > why 16K was chosen, and hence bumping to 32K in order to cope with
> > current systems generating output faster does seem appropriate to have
> > a better user experience with the provided defaults.
>
> Just to record what was part of an earlier discussion: I'm not going
> to nak such a change, but I think the justification is insufficient:
> On this same basis someone else could come a few days later and bump
> to 64k, then 128k, etc.
Indeed, and that would be fine IMO. We should aim to provide defaults
that work fine for most situations, and here I don't see what drawback
it has to increase the default buffer size from 16kiB to 32kiB, and
I would be fine with increasing to 128kiB if that's required for some
use case, albeit I have a hard time seeing how we could fill that
buffer.
If I can ask, what kind of justification you would see fit for
granting an increase to the default buffer size?
Thanks, Roger.
|