[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
- To: Jan Beulich <jbeulich@xxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Wed, 29 Jun 2022 15:16:30 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R7fcrvHDe8RBM3bVEbVpaF7WqyvBuW0KTWFqviKM1JI=; b=lLRuHB+QzwztBQu1xMdKkOEAWY1rMlz/frUc04Ryyi8phlyKVpHO4CatAdi4LDh1hCwhknOCgMu+q0uCsq8qs5ti/Go1EY6wDFRF2i1oj4DveVDFyGyEhf+iHQZWbs9Ilo3HGN4MbJl8CEpKd6uJ1TI7we3TBaZcdxIrWUAMNQnNTddvWLcNwrJoD12C6Hezhwy5CFkGQMqZeurNECONiNHFraO1ihJ5eHU6MfH5gyjWyYvDiALStVt9a0z/5CXdvkXTLxyglKliWBTxlHOmft2ftR7bkCrwa2bmPQUCRIZpfU8rsy7H0urn70miZL1HYj62gkNGJqokOOmlFhgugg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b0z/6Nfkxcaa+QrpQlZwrLdQM447xEPOqTcVWWiNEDtaEJOXTlhGKvxy9uCuFji1/srb62C1WAWvdcbHJvTzeGEt7fYMuuFOj2qBFHT3C5gvEYwlDLxhBkr6HVzjc2YIQmuZazKfgM8ZSAuKNmcfa5c+oug8JsxK7XuD9Ok2oGHhd8QA4PoQA1uu2t+xTJOAWz1iB03b3D6YM1qu5fCCSJs485fsPktcP9jdSv9LFq3zDbKdNJUvx4Px0uoG1SoynWXLgV65USFF/Esx8rxel7mCnbK1xNEdk18ZoSMzw2sgspTTHrf7EE7JbyLWNYq2fye3KzYktF468h6V8v31jg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 29 Jun 2022 15:16:44 +0000
- Ironport-data: A9a23:wvBi5KOLzJBv5lfvrR1ulsFynXyQoLVcMsEvi/8bNHDolHp+jmZWi jtAB3bbeeLOPDejS21E3dSHQXl2v8XXzNVjGwc5r3pkQiMU+ZXMW9nGcEqpZn2ZdpObERg75 p9ENNSec5hkRyGAqkqhb+Ho9iMi2auFHLOhBLSZYkidKeMKpAIJ0HqPzMZg39M52rBVej+wh O4eg/EzGXf5hmR9bzhOsPre8Usw5quq5DlHt1FjOv0T5gCFnCNNVMNDKfm9IUWjT9gPFIZWZ QpiIJJVXI/9101wYj9wuu+jKiXmepaLYU7WzCA+t5GK2nCunARrukoAHKdaOB0/ZwmhxYgrk o0T783oEG/FA4WX8Agje0gAe81BFfUuFI/veRBTZuTKkiUq21O1qxlfJBle0b8wo46bMkkXn RAsExgfbwjrug6D6OnTpt+AJCgUBJKD0Is34hmMxNxCZBosacirr67ivbe00Nqs7yzn8Dm3i 8cxMFJSgBr8jxJnFxQbL5wykf2TwXjNfxxnp3nI5oQ1/D2GpOBx+OCF3Nv9XPWvHJ8QtGDI4 2XM8iL+Hw0QM8GZxXyd6HWwi+TTnCT9HoUPCLm/8f0si1qWroARIEROCR3n/r/k1wjnBYI3x 088o0LCqYAQ/UqmCPz0WxS8qXiJlhUdR8BRA6sx7wTlJq/8vFrEXTlfF2UphNoOpe4yRRh23 w6wmNbvNwc0v+OVEmi+3+LBxd+1EW1PRYMYXgcUQA1A79T9rYUbihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpcsC1qH+91aXhTup/8LNVlRsuFWRWX+55ARkYoLjf5av9VXQ8fdHKsCeU0WFu 38H3cOZ6YjiEK2wqcBEe81VdJnB2hpPGGe0bYJHd3X5ywmQxg==
- Ironport-hdrordr: A9a23:gN8GEa9gbane+QU16shuk+DOI+orL9Y04lQ7vn2ZLiYlF/Bw9v re/sjzuiWVtN98YhsdcPG7WZVoIkm2yXZ1ibN+AV7KZmCPhILPFu1fBODZsl7d8kPFm9K1rp 0OT5RD
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYi8AZy145ktbIbk+rkdBDuBblea1mcQoAgAAN3AA=
- Thread-topic: [PATCH RESEND v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
On 29/06/2022 15:26, Jan Beulich wrote:
> On 29.06.2022 15:55, Jane Malalane wrote:
>> Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and
>> XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and
>> x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization
>> can subsequently be enabled on a per-domain basis.
>> No such features are currently implemented on AMD hardware.
>>
>> HW assisted xAPIC virtualization will be reported if HW, at the
>> minimum, supports virtualize_apic_accesses as this feature alone means
>> that an access to the APIC page will cause an APIC-access VM exit. An
>> APIC-access VM exit provides a VMM with information about the access
>> causing the VM exit, unlike a regular EPT fault, thus simplifying some
>> internal handling.
>>
>> HW assisted x2APIC virtualization will be reported if HW supports
>> virtualize_x2apic_mode and, at least, either apic_reg_virt or
>> virtual_intr_delivery. This also means that
>> sysctl follows the conditionals in vmx_vlapic_msr_changed().
>>
>> For that purpose, also add an arch-specific "capabilities" parameter
>> to struct xen_sysctl_physinfo.
>>
>> Note that this interface is intended to be compatible with AMD so that
>> AVIC support can be introduced in a future patch. Unlike Intel that
>> has multiple controls for APIC Virtualization, AMD has one global
>> 'AVIC Enable' control bit, so fine-graining of APIC virtualization
>> control cannot be done on a common interface.
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
>> Reviewed-by: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> Could you please clarify whether you did drop Kevin's R-b (which, a
> little unhelpfully, he provided in reply to v9 a week after you had
> posted v10) because of ...
>
>> v10:
>> * Make assisted_x{2}apic_available conditional upon _vmx_cpu_up()
>
> ... this, requiring him to re-offer the tag? Until told otherwise I
> will assume so.
It wasn't intentional but yes, that is right. There was a change, albeit
minor, in vmx from v9 to v10 so I do require Kevin Tian or Jun Nakajima
to review it.
Thank you,
Jane.<<attachment: winmail.dat>>
|
