[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 01/25] tools/console: have one Makefile per program/directory
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 8 Jul 2022 15:08:46 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aslPFKamwsS2JBQ+nkIatLqI+rrqW7VJW2AJHpFWDSI=; b=fFL6LmLBoXzL8injvPKnCDUAlKf50JYsL69n9YTInUeRiv1cChFNpAoVSpsPWhxyjWz+aadI5e89SxAZB/07uf5qjhv1r2+tdVaLHzzGdfpDBbSyzMM1NVq9eJwkKWC/+tn643gi2V3YWmeHVc0PUDUPeF0VjgM2Ti48AOnVgtCKgS9m2SNKXkqQIhkls+uSHQKgDQAPIZWlJNVfx0udYFM1Abc8+RDNvGiGYYoQp0+P4/IyncvTL6hpriCnEDWPGwVLjq6A5s9cscW8S9WaZce4NFWDjIkbzScNHTePNYiKhnMIA3xs28DhqP7pd4WKEyDQHJExwYlaWC2vRXrK6w==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aslPFKamwsS2JBQ+nkIatLqI+rrqW7VJW2AJHpFWDSI=; b=EOE4N6pXegCpf00ZSn1nP3yjlt6HkgDHqcC5T72wawYFz2gNW2YlDcI8fmcy4Pwu+hWVxrU8SQ/FLeGxe5OXZxMaBLppmFy1Ab2u65jktPFmbUpttyRfKwU0xrulIjSjnFnnzAv/n58y62BNZSfZri1BtYzQQAKKK5iIXmOZBA62x/3PmtdUTtDPLLpS0LC11MNt0XazLTOkNz+ltiwOtxMy0ou7moXijtzVxd6H1g2mfmMH01gx/YD/vQk1WV6z1JKaGQic/L7kysVXL4k13376gvA8XFfBAlFGzrDO4pIWUw0Iob2V2cKKk0oHbX8A9vi1VdTSrZPu9HYiHiLaEw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=K1aeZsQCgdVnPV9AeUV18yUlfOymJxAb4MjX6UaSJc0DRDfrSO9t+xnm+glxSW2HCcTw4ms8PSibOUWHi+7yktHrgb5CIGXx4r39FGCIMAn5P/v40nEY8MwANIfu4l3vgkeOItsp2+AMkwpCepOo53tyOZxKSqMV3yzL4Bv7uviB698JGxUD+aer2DwMuKmJGyRbJWity2u4ifaXD/P8C2ksaQYq1obktv0mEQJc5KnIdPA89EQzmvJSM4THyem0ANSGGyK06tc3xdJqloi1g6GrT+jGgx/wP64xm+S3jqsWu1iii/qNi8e/BUu7Om3FO3oBNLej2OHMZrDJH9I6gw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T1rUz410CoB9m2+Cj9GxBQ5qv8EJxCPMBPOrkh0spA4Fi8H4wtoX1lqywA2n+aVl3k2+95JhRwXcAcgsiMLviTGcwhKSAUSgn9JZ1CxG5xdWMV7goKsuhkHkwd0GksF02cU+j7qo7eMFzLHB9hJ4U9Y8IgixhlIXYXgccKjBEFGIRbOG3wBMPQtKRD3r0kjRPqUjfGY/22PkIvpm44wV6lgrUA2wzsf+FfA1Pk20buqNpvPXrLKEUlNXtvUpsFuAuNINGe5/U0bCwmHWrdwYqvmjOrEthq/ZN+1//M9fTvNia13y/DMH+ZAIgChePeIDN2Cj8TgxBJP6Emcvhhu/+Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 08 Jul 2022 15:09:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+QzkA5fhHLZ/km46EVDQz/TQa10qXOA
- Thread-topic: [XEN PATCH v3 01/25] tools/console: have one Makefile per program/directory
> On 24 Jun 2022, at 17:03, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> Sources of both xenconsoled and xenconsole are already separated into
> different directory and don't share anything in common. Having two
> different Makefile means it's easier to deal with *FLAGS.
>
> Some common changes:
> Rename $(BIN) to $(TARGETS), this will be useful later.
> Stop removing *.so *.rpm *.a as they aren't created here.
> Use $(OBJS-y) to list objects.
> Update $(CFLAGS) for the directory rather than a single object.
>
> daemon:
> Remove the need for $(LDLIBS_xenconsoled), use $(LDLIBS) instead.
> Remove the need for $(CONSOLE_CFLAGS-y) and use $(CFLAGS-y)
> instead.
>
> client:
> Remove the unused $(LDLIBS_xenconsole)
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Hi Antony,
It looks good to me.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
