[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 02/25] tools/debugger/gdbsx: Fix and cleanup makefiles
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 8 Jul 2022 15:23:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=njPODwD1bMmyTOF+1F7iWEpiew4wqIZuy7x2hUUoqhE=; b=IAJyMViybLDN6FUBNoZebqUXG14f7s8tIbvPTqBBbMwSg6eF/miRpDtjAS/e6fNIcQ1+Cpz7fTStb0WlcshbSOfVAOF3dgFsbRClF9elJOkjy22cGcXOVUylwjpYD/qGRuNKVnWlKG7rKP7++PuO0vhh1wMcwj0+zWJuOQfB0BwhzpQgHDwK59Lt0RhIKL6U6RRmJ+/pXsIt2lYBTOY8CC18YIcJ2YB8Clu8WdP4dVIYBM+AqACEFfRjTZvyA/WbMH67SkTQOdh8vjLV4igR3lk70eV++7Livw4vOrUBypRrUc6jcHLsQAfKgLs9yaLR/Js6L2uUhKgw3re+IHDhFw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=njPODwD1bMmyTOF+1F7iWEpiew4wqIZuy7x2hUUoqhE=; b=N8wc5pMlUcaKd13Nyi6uw4MYqj4hREVkUw8rdxi0BiN5tSbjwmLP0ig/40Sxj1FTHKLsc/Ju/HKpTJ3ifpo20fYiq4yGCr6x8Ub/hBu2Arp2zdUnWNcps6ockKz7r1KsBGeAiD1l2srn3Geoot1FE5jF7+ABcSqLKWQrf+BVZwMm4h6mJovLN8n9dgk9CSW6mfPha4c0eK7dj/W3Z3afAaW80/UjOV3w7dHBHa6O3z11a16mA74VXI8SntWzBrG9tXAEatFAy7s1TCSLOaQLor1LJ0gubOxQZY4Yp8n3b1KecLiO+K7T72yvmCRdtBTyJP3mXKjLEWqoMS3YJPX7NA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Tc8Qvg1eWsf44+CP4JdRIuvt1FrirVwbwDZ1cVecp5WlaBh/+PZ+1R8xW+dr3pP/jvv4bCslw8320TfYfwBBwY11DN/u9sX7BRotvVKaaVE3BMS40OEloemMQSxGoiVAKhbpkACsNwFTPUqMpLjcaNFrfdTKsRkmCgvcKw3vBPKj46k3ht+GnljZdBnaLvR9SXzw5K/t8tHvd8vw98i36JiwlMVtebdEOyRh0f+N58vA1JqLEVdISXAyU6BZ8W68ZntbN6bS5q/tUxCu8EwLzt+o0RbKyR1i+DGfHA7Ft+B/Nmn6sYfTDePxroggatltfIQB+p1h6f4VCI4J2Rm9GQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UnQ00g6tlUvyltLAHjgCl5+vzxUSDD2sZsHU5QGLO4QAioJVGn8s0lHRKvsQOb7ne4XowDpJMJ4CM+HhUkjORc27uU5RIynJEoQmVBBCLqnG2UTGDgrZ7bRBqQ5ilN0gWdofmZuG+Jgnpkl5sQbXUQQKcIWvqPEO6bfgeKjxm7BsFlV9cTO09HkmIZVlBqlNDA5ELg4W5VVvj2oVa5lmSv7V0m1RZk+K7nFH6qxs+uBwoVR2j9VY+75yj3UAq/C8zmeP35fbxhY+r3RNq3FbmmKj2DB4Pp1qJVJiGonAceHlGrwkxqtt6tcNy6XBtjpiCMzA8Uv4o9GRA4Afw6zs2Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 08 Jul 2022 15:24:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+Q7ENxA0CLOIEej7JYABIo4T610rZ4A
- Thread-topic: [XEN PATCH v3 02/25] tools/debugger/gdbsx: Fix and cleanup makefiles
> On 24 Jun 2022, at 17:03, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> gdbsx/:
> - Make use of subdir facility for the "clean" target.
> - No need to remove the *.a, they aren't in this dir.
> - Avoid calling "distclean" in subdirs as "distclean" targets do only
> call "clean", and the "clean" also runs "clean" in subdirs.
> - Avoid the need to make "gx_all.a" and "xg_all.a" in the "all"
> recipe by forcing make to check for update of "xg/xg_all.a" and
> "gx/gx_all.a" by having "FORCE" as prerequisite. Now, when making
> "gdbsx", make will recurse even when both *.a already exist.
> - List target in $(TARGETS).
>
> gdbsx/*/:
> - Fix dependency on *.h.
> - Remove some dead code.
> - List targets in $(TARGETS).
> - Remove "build" target.
> - Cleanup "clean" targets.
> - remove comments about the choice of "ar" instead of "ld"
> - Use "$(AR)" instead of plain "ar".
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Hi Antony,
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
