[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 7/9] xen/x86: rename bad_srat to numa_bad
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Thu, 14 Jul 2022 09:17:44 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHIaqGKAV4GSAaAAgx/n/6Xin3AeRZwXkbmphePOUgE=; b=kWtWPrNgVBC8u/1slDXk7KEobBvy+6UP0V3WsqK4TDdNuISHVlX5rIIzjWhLKc49jFJiaE2RU8YHj/3mti5nIvciLkMeWUEc5YqpCZTyrTKv7+krgxM/YbfevLZJl9NfxPNXIlqkPzrFaO4mnWPHU+1rNrX7oLXR6tZgQHfsptJvzR4wXZPcPHhjkgfIpjAD1d1TjBVPzAHiv27hlb72q+Nj96KB5czAGUS2mtPkyqxnlcXHK3DauJTA8oQ3jJg0qhPSGVIzhoOqq2dytKzAVmkc83Vd2xAzcJNaKifF9bLRd0/GpJ6A9YB7lVZJ9jAhhHzrvox2N559y5FsD7u4JQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHIaqGKAV4GSAaAAgx/n/6Xin3AeRZwXkbmphePOUgE=; b=ga12MosjF8XnuFJq+51GCOmII/n/XSgpbX1kmYxuymRvSfrbZ1C7QZKE1zwC/N3f2x/DLt8mO98EYl51Tf1amLA/atimvCzcvXbD+puldhScqJNFyYQNK9cn0au3m4OFfpDX5jFNA52JGPbDzMa5dsQzsLed7fSCLmwI7Ea7QDEFNEUFQdWBV5wnX34trEEY+8/a+r2yYV8UESJ+IaIGSGccVFde54jiM0hU8UvkEy6sSe7wp7hPprDu9zF2lFW9KYoJBdaP3pN8wGLMuef4c3xR/57a09zNw4MY6F9OyiKzOnFUd0uBrdVJws4+jJV5f6Rg5X7GbtbXmovjLoci7A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AbW4VT52VwEo8MXrH8ulsfrm5OIkym6MneC1KxG75i4EenE0b11Ruam26xZP2MfzjVss6xT0ny0r0K/hKVaQ6GQAN9Ox4EPhZORRvkS0SHMGewisTWZ/i1PgCnsB5Wc1KiqCv8uQwSrfWvrGbgu89VCCKUZ7ERw3UyAFIcdup76qgAxCGTegGYtqSxg2/lEVWvWk4XNLgCu2SsJah3A0YKmEtjjKMfLSIdvTerDIEcMKCyN3Ct8xprs5hFK/dvZDzijUwPLR/4ODhIzXE54g/qj9d1imqWUhPb9kYweZEQbyEmhGQq4+hXNHvlSF0oWpNBE75UQ4SWVaHoORNnw4QA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XgtImSabczKKtsrR7bSgzNgd3UcJZGcEpXyhcUWgf6vt3qt6bdR0GrVLKe8Sa2jYmFgzFWd45cjd2unpgS2+oriEBHsoN9+2j56d0o+mjCNUJzUmQ2y29h+2C4/F4hdUHoGMje1FoSm20Is0eXJg/K7u+Vl/2hRUMqxsi2q9zp/E9qRKeM6d3prfTW8aCCjVCTAQMv+F1MYcqTbAvia/DEAkDXsony81kACJOsx2xaawZ9iX6woNj1daD79deVoL5XmJcFkWxE6JZ/c9r/qGYUx7fsjuzWhAEeWLtp10y/PjHJ1J+kLyaLUgwValBkIxXYhlYx3UVUBI5aIkpLfXqg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 14 Jul 2022 09:18:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYktrEQRgCjYljLE+D+LLS9lLfW6160MYAgALOd4A=
- Thread-topic: [PATCH v2 7/9] xen/x86: rename bad_srat to numa_bad
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年7月12日 22:26
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: nd <nd@xxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau
> Monné <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; George Dunlap
> <george.dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 7/9] xen/x86: rename bad_srat to numa_bad
>
> On 08.07.2022 16:54, Wei Chen wrote:
> > When NUMA initialization code is failed in scanning SRAT. It will
> > call bad_srat to set disable NUMA and clear relate data. But this
> > name is ACPI specific, we have moved generically usable NUMA codes
> > to common, bad_srat has came with these codes to common code. But
> > it's not reasonable for other NUMA implementations to implement a
> > fall back function named bad_srat. So in this patch, we rename
> > bad_srat to numa_bad.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > ---
> > v1 -> v2:
> > 1. New in v2.
>
> I think this wants to come before moving to common code. And I'd
> also like you to consider using e.g. numa_fw_bad() or
> numa_firmware_bad() to better reflect the original purpose.
>
Ok, I will re-order the series and update the function names.
Thanks,
Wei Chen
> Jan
|
