Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status

[Jan Beulich <jbeulich@xxxxxxxx>]

On 14.07.2022 11:55, Wei Chen wrote:
> Hi Jan,
> 
>> -----Original Message-----
>>>>
>>>
>>> Sorry for replying later, I paid sometime to check the code again,
>>> and drew a table like below, I ignore two columns when numa_off=true
>>> and acpi_numa=1/-1. Because when numa_off = true, ACPI srat table
>>> will not be parsed:
>>
>> While I agree with this fact, the problem is that there are two
>> independent command line options driving the then single variable.
>> IOW numa_off and acpi_numa both turned on may still need a
>> representation. In fact I'm not convinced we can eliminate the
>> original variables. What we ought to be able to do is consolidate
>> their values into the one single new variable you add, before
>> ever evaluating anything. _Then_ I think I agree with the table.
>>
>> Jan
>>
>>> +-----------+---------+---------------+-----------+------------+--------
>> --+
>>> | original  |  col1   |  col2         |  col3     |  col4      |  col5
>> |
>>> +-----------+---------+---------------+-----------+------------+--------
>> --+
>>> |numa_off   |true     |false          |false      |false       |false
>> |
>>> |acpi_numa  |0        |0              |1          |-1          |x
>> |
>>> |numa_fake  |x        |x              |x          |x
>> |fake_nodes|
>>> |enum state |numa_off |numa_fw_nodata |numa_fw_ok |numa_fw_bad |numa_emu
>> |
>>> +-----------+---------+---------------+-----------+------------+--------
>> --+
>>>
> 
> How about update the table like this:
> +------------+----------+----------------+----------------+------------+
> |  original  |          |                |                |            |
> +------------+----------+----------------+----------------+------------+
> | numa_off   | true     | true           | true           | true       |
> | acpi_numa  | 0        | 1              | -1             | x          |
> | numa_fake  | x        | x              | x              | fake_nodes |
> | enum state | numa_off | numa_off       | numa_off       | numa_off   |
> +------------+----------+----------------+----------------+------------+
> 
> +------------+----------------+------------+-------------+------------+
> |  original  |                |            |             |            |
> +------------+----------------+------------+-------------+------------+
> | numa_off   | false          | false      | false       | false      |
> | acpi_numa  | 0              | 1          | -1          | x          |
> | numa_fake  | x              | x          | x           | fake_nodes |
> | enum state | numa_fw_nodata | numa_fw_ok | numa_fw_bad | numa_emu   |
> +------------+----------------+------------+-------------+------------+

Well, this makes the table complete, but it doesn't explain how you mean
to fold the settings of the two command line options into one variable.

Jan