[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status


  • To: Wei Chen <Wei.Chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 14 Jul 2022 11:57:53 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLzcafsrwjrqsew2vwdKnFBz6cWZ1azva8NG24mJ74E=; b=Qvi5f2YY7qwB0Yaa0YShCee3BcZ/ivpvq3RRpLRlIhTn6JaDpWddd28Z3/Vkyt32DRw8uo/qZ3q1iwlqbogkJQhBcMBpNCZhh1MQ4YKAJFqu+eNuzOPwNq8oonvFrFTg3jwc+pwNcoB0hQY8yRuhvXE9ZYRb5PItOjgE3JtK0UQR/oxR8l/9OXefYM6oaegc6z0EvpN1obIXlcNGLo24zRuj5lW9Vq6Ww1qxDTGiQZEEO+EujW02i9cn3+6kVu8uaIaYeKzekcKV7YBs/Dbfae1KRbvB26VIrOOdjEz9szOT0VXOdluRl0kFTawlRhFfRa6voCqF4/TvNBjTDzJrPg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H+/MJ/uri/zZnnvASeWLcdbiSfRzcpOSNVlJAMlnoyvYUB0/Wq/egAmA4GM16pXqtwQo/4bdor8y1mrXdO9w58xPMSxp28b0dcNg9+X9FMDKSZKTJxfhoQLka8WqlLCOBQcTfVVPP/ng8E1UDMgcNaVV+gwErJBn0W1FukEE5qPZuVI1MERW9i1kjoRZvFqdt4LN9jbzl/chQOAlurUS8pKWLrGTiSPb4ScsQ/xgOWlAo19iy6sJsA2mjEkYNMtWl1Kw2Y0CVY6hcHX7NataTzeVxeGsQDBaHboe+pUY3IA2mvYH1Q0KucDFhYMhl5DmmdAsFMC5OUWF7XAyLEHP9w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 14 Jul 2022 09:58:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.07.2022 11:55, Wei Chen wrote:
> Hi Jan,
> 
>> -----Original Message-----
>>>>
>>>
>>> Sorry for replying later, I paid sometime to check the code again,
>>> and drew a table like below, I ignore two columns when numa_off=true
>>> and acpi_numa=1/-1. Because when numa_off = true, ACPI srat table
>>> will not be parsed:
>>
>> While I agree with this fact, the problem is that there are two
>> independent command line options driving the then single variable.
>> IOW numa_off and acpi_numa both turned on may still need a
>> representation. In fact I'm not convinced we can eliminate the
>> original variables. What we ought to be able to do is consolidate
>> their values into the one single new variable you add, before
>> ever evaluating anything. _Then_ I think I agree with the table.
>>
>> Jan
>>
>>> +-----------+---------+---------------+-----------+------------+--------
>> --+
>>> | original  |  col1   |  col2         |  col3     |  col4      |  col5
>> |
>>> +-----------+---------+---------------+-----------+------------+--------
>> --+
>>> |numa_off   |true     |false          |false      |false       |false
>> |
>>> |acpi_numa  |0        |0              |1          |-1          |x
>> |
>>> |numa_fake  |x        |x              |x          |x
>> |fake_nodes|
>>> |enum state |numa_off |numa_fw_nodata |numa_fw_ok |numa_fw_bad |numa_emu
>> |
>>> +-----------+---------+---------------+-----------+------------+--------
>> --+
>>>
> 
> How about update the table like this:
> +------------+----------+----------------+----------------+------------+
> |  original  |          |                |                |            |
> +------------+----------+----------------+----------------+------------+
> | numa_off   | true     | true           | true           | true       |
> | acpi_numa  | 0        | 1              | -1             | x          |
> | numa_fake  | x        | x              | x              | fake_nodes |
> | enum state | numa_off | numa_off       | numa_off       | numa_off   |
> +------------+----------+----------------+----------------+------------+
> 
> +------------+----------------+------------+-------------+------------+
> |  original  |                |            |             |            |
> +------------+----------------+------------+-------------+------------+
> | numa_off   | false          | false      | false       | false      |
> | acpi_numa  | 0              | 1          | -1          | x          |
> | numa_fake  | x              | x          | x           | fake_nodes |
> | enum state | numa_fw_nodata | numa_fw_ok | numa_fw_bad | numa_emu   |
> +------------+----------------+------------+-------------+------------+

Well, this makes the table complete, but it doesn't explain how you mean
to fold the settings of the two command line options into one variable.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.