[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/P2M: allow 2M superpage use for shadowed guests
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Mon, 18 Jul 2022 05:42:22 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bV06MbpGMcLYbTL87gpdq9MyUV/jcZP7G81t3heswKk=; b=OijuQ4W6kjcG6od6ugYi419TDZ76EAcBiNSS62rawRd1zUe3JKxU4ykbRn77dvweyu2j5EIMcOBNsrH8MKp3JhxnsNgsdUZd7B+ez12y27HzgrhwxwXw7ZmA5wcwd8Ss9KWhyzZVU8EfmY/YgiT2UbfiI+AmoN7UZyOuR2K9VoWsDmj8Gbv8pVsvdq7HHeW54vhfqxnQXXcJkTcSI/ND1cEtNSuMLk86z4bqZ+0L0j1LzIHGaY2BUoPZeqZjH2+9IX6N+hVk252NxL/CUlIoEgz6tQgVnENXWGIG5jc+DsPAGXGqDQ3F7L0CR6E0kilRuC0gdHz82anEWejjDrzZ3w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iKQn3EX2kdWIaWgqG3EBToJhnIygrNcoH7WuC4EntoHJ/PQCIWVSffIsFIM5rtaI8xSSL8cmomJzrj20Fk7VLhFyCMqsPsvbBYwlLGJrq6v84Fn6U6rP5uuou5MHb70o6Ot2bA93cZV8SSxEfEfRsQvq/S50raFZP0lAkVv3WFjLqC11VeW7CXDUnrObJyGQQo3zCrtaWQySeKaMFhXhp+f3GZ7M8xox2kkZyZJAYIXNDqqOxIQ4TUE3G0BYjr00Wd/bwoSnLd9JLutvUx16A3kWfQgl2GPNBUJlPCbMjx1QrOldUlDnAQ7mH1k63MWkYZC790ADFP+qf+s8DUDgIg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>
- Delivery-date: Mon, 18 Jul 2022 05:42:43 +0000
- Ironport-data: A9a23:q+zM2qzsygtTw+A+YYl6t+eqxyrEfRIJ4+MujC+fZmQN5Y8a5oE1v iFGDjfXfrrIN3ykOIpG3L7G/UxXupDTytNmTgBv+Cw9Qn9D9ZDPWt+TJ0qpZnLIJJOdHBo+4 pVCNYGRdZE/Hi6A+0z3bee583J3iajZSOqiA4YoVswJqSpMEU/N3jo/y75RbvdUvOWE7yOxV fLa8pLRNVOogDUkbT5E5fzS9kxm5Kv/6WkTsFBgPa8a5QGPy3VNAJwhfqzgdHGQrqu4vwKZq 0Qv6Jnjows1Kj90UovNfo7TKxFMGPiKVeS3oiI+c7C4hRRfrTAF3K8+Nf4NAW9akDzMlN1qo Dl3ncXYpTwBY+udwozxbzECS3skZfIfp+edSZSCmZf7I3PuIiOEL8pGVCnaDaVAks5rDGdH8 +AvKTxlRnhvUMrvndpX4sE17igSBJGD0LE34xmM/hmAZRoSerjRQr2i2DNt9GxYavaivxrpT 5FxhTJHNHwsavDUU7sdIMpWcOyA3hETf9DEwb48SGVeD2X7lWRMPLbR3NX9ZNDRHeBsrGWkj 2fWwD7FATU7LP/O4G/Qmp6srrencSLTfqs3Tef93Ng6xVqZyyoUFQEcUka9rb+hkEmiVtlDK ksSvC0zsaw180/tRd74N/G6iCfc4lhABJwNTqtjt17lJqn8um51AkArQzlbZ9FgmNIwQTUy/ lSIg8noFXpkt7j9pXe1qenM9WzuY3d9wWkqSh1aEBoj2oDfjb5slh3LTdt4L4OKt4igcd336 3XQxMQkvJ0Rh8MW06Sw/Xjcnimh4JPOS2Yd9gjRG26o8A59TIqkfJCzr0jW6+5aK4SURUXHu 2IL8+CB6MgeAJfLkzaCKM0RHbSB9/uDdjrGjjZS84IJ8j2s/zupe9BW6TQnfkNxaJ9bJnnuf VPZvh5X6NlLJny2YKRrYoW3TcM30aznEtejXffRBjZTXqVMmMa81HkGTSatM6rFySDATYlX1 U+nTPuR
- Ironport-hdrordr: A9a23:7PCacqNB+YAkkcBcT23155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90dq7MAnhHP9OkMQs1NKZMDUO11HYS72KgbGC/9SkIVyHygc/79 YtT0EdMqyXMbESt6+Tj2eF+pQbsaC6GcuT9IXjJgJWPGVXgtZbnmJE42igcnFedU1jP94UBZ Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29JOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W /Z1yTk+6SYte2hwBO07R6T030Woqqg9jJwPr3PtiEnEESotu9uXvUkZ1S2hkF3nAho0idsrD CDmWZnAy050QKtQoj8m2qQ5+Cn6kdg15aq8y7nvVLz5cP+Xz40EMxHmMZQdQbY8VMpuJVm3L tMxH/xjeseMfpuplWO2zBZPysa6XZcjEBS59L7tUYvGLc2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcFEgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xCvefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzvewPcV T6ISdlXEIJCjLT4Je1rex2Gzj2MRaAdCWozN1C7J5kvbC5TKb3MES4OSUTr/c=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHX7O/bKX0sOdH9/0aIlntq4rv2Q61gJw0AgAPel4CAIPLIgA==
- Thread-topic: [PATCH 2/2] x86/P2M: allow 2M superpage use for shadowed guests
On 24.06.2022 21:27, George Dunlap wrote:
On 9 Dec 2021, at 11:27, Jan Beulich <jbeulich@xxxxxxxx> wrote:
For guests in shadow mode the P2M table gets used only by software. The
only place where it matters whether superpages in the P2M can be dealt
with is sh_unshadow_for_p2m_change().
It’s easy to verify that this patch is doing what it claims to do; but whether it’s correct or not depends on the veracity of this claim here. Rather than me having to duplicate whatever work you did to come to this conclusion, can you briefly explain why it’s true in a way that I can easily verify?
Would"The table is never made accessible by hardware for address translation,and the only checks of _PAGE_PSE in P2M entries in shadow code are inthis function (all others are against guest page table entries)."look sufficient to you?
Sorry for the delay responding to this — yes, I think this would do, thanks.
-George
|
Attachment:
signature.asc
Description: Message signed with OpenPGP
|
