[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings()
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 18 Jul 2022 10:47:38 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uvsjDqGL2BujawmzknEtMFgCpnNttGWLdgUDtHSTwH4=; b=RT3LQwoGME3AgwiLjm6p4A17fqYTIpC+IdCxBL3ZwCIpzbB5BKhUq5+ZpjcAjV0ls/xqb4wRxDjyAdU089tjJW+GAzCTZW4MMxDtknv+8LA8CCjjl8JksdCXP6GRZ/mB8x0/92IZFgl67FJ65DVsT2DfQ5k+JF9DRzXfONVe18kCp/HEaAu9QoPs3VDEZ2pqJcCHAKN/U4kl06XoLYuswJS5WpfE/4PUuLEcvukFdaAtDhzmhcyfbLLl13uUqr4TMPOQtCc744Ld0+yJTTmiOrObSVoCAqlQoITekuWNlVWP1bW89CH/iPh3X0X3maTTdc+84WY6kC8muJyQIWlBLg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iWiqeX7Hb3ZWJkPs+chvXDZjCUgh5mxomnmtdbzc8Vh54ZgU8pkMV0VRO5ME6turwmDVoKwSTemICYDfIzNelly64uRIoe8NcUTeag/W0OdKkDE6l+SAj0yUIaLtzOnIHjjBEM4LRPYpN3hAn4litsyUXFOaMUWjYKJKeuKdjBnCaj9OKCTFb36NRqpjuK1JUjml8By1uJnIBrS2RBurtD6iO1V3bbuc6odUqgtbS3gELF1PnFHZVQvoDajSpYWn/sFnvQVYV6RqoAIZbQ84nTl5jMgbTrL5yp7xBRIYeeUdrgLXsyyTJEaPBdVsOYvm+dbuCwuTEyx50jFoKJ2W6Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Delivery-date: Mon, 18 Jul 2022 08:47:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.07.2022 16:38, Julien Grall wrote:
> On 04/07/2022 13:35, Bertrand Marquis wrote:
>>> On 24 Jun 2022, at 10:11, Julien Grall <julien@xxxxxxx> wrote:
>>>
>>> From: Julien Grall <jgrall@xxxxxxxxxx>
>>>
>>> Both destroy_xen_mappings() and modify_xen_mappings() will take in
>>> parameter a range [start, end[. Both end should be page aligned.
>>>
>>> Add extra ASSERT() to ensure start and end are page aligned. Take the
>>> opportunity to rename 'v' to 's' to be consistent with the other helper.
>>>
>>> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>>
>> With the prototype updated in mm.h as suggested by Michal:
>
> Done. I will send a new version shortly.
I notice you had applied and then reverted this, with the revert saying
an x86 ack was missing. I don't see any need for an x86 ack here though,
so I'm puzzled ...
Jan
|
