[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 18 Jul 2022 12:48:14 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TWYiKj1v9skZopvMgCoh4nulmfHARZA6J/VFo/hpWhk=; b=hgK2eKnKBY9zZTYAR1kgY/aLZbk0WgRonErjFoAgkgotEaxqeriAv2necyhY7tEEmb03/AXFWp+95uKszIvxU+AdMKwcW8fdbk3NwxtXTzWuI9d0+IX7DdMgvHYRqbvS3x65feeCOjdGlgjV6Hy6tgpVYX7tZ5fq0xqWIYSpZoxjXMOmmlITWNQ41s/KqvH1MfkhoHTn1fDZ++tlWm0yrf9dCj9xpF6mAXqTArRql7U377uF23m0wDUOeJab32VIICGWezoQYxjKryOl0o/JmIFiqMtqyNkjvqFWMcfYvl7jd31/qd0W/QvMkucrRJxcz6iKDoVsGtbMxuFIo4M8YQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=amgXt8zuA8Kbkikgd9nQq57HKgkuwY6ezXeyo+XpXbyGhl5W6pZSPUacsQxY+Bab45hZMV+cF8qO7kie3ExLz84Jt50oB66I7VQZQ+bjP9t9/CfEMtV5bXMTZ2lm1LaeV7r5afwOAXLDlhRuMq3STvaSabt7IlXP8Z/whyByZqgTKK/U13GX5B7NCwq5BXTVHbL64JnIpKYuWOFmp7QBoY77URrLJ2yZ5YMUAxE3v4HKIKim6a+27yQDTkLwbkilftVc3OOVR/UL5meS7MujcnHwVgsDHajm059j9Pd4Xw2lQIkyu6NwOUrfl1ZuUoKfPga+jsAN1XUvqXPLs4ewdQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 18 Jul 2022 10:48:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.07.2022 09:18, Andrew Cooper wrote:
> With the waitqueue logic updated to not use an absolute stack pointer
> reference, the vCPU can safely be resumed anywhere.
>
> Remove VCPU_AFFINITY_WAIT completely, getting rid of two domain crashes,
I understand you mean two domain_crash() invocations here, but ...
> and a
> logical corner case where resetting the vcpu with an oustanding waitqueue
> would crash the domain.
... some other domain crash here?
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I assume you've checked thoroughly that calling code hasn't
grown dependencies on execution coming back on the same CPU?
Jan
|
