[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 18 Jul 2022 11:16:31 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jQ6SV5L2fOkcTpQm3rLauT1+hLDdkCcBmrqmoMTzBcc=; b=e7VZxjt2TRl115QqRvTImQ8TI2omtwusGDWBonAGMCmKFpvCovSL5UIOgf7674YC4i9qP9w3TONPEPvgzBaIPfDiySYyEYvyaEvB9/yLrrnwobm7Sykh7W/YXKToor4CuzN7v+U4XkYEE2CLWLIK3I7P7udJfqHvvfCGodLNwkNqLDW6eUqqJU/Xc9/0Z/b3VQCNwyqY4pVzxLiA9fHfbpcNH5pP2rKryAL4mWG7tCJr4S9T92jmSaAFr4WJjNfgLbWRnjHPwen19voiBDduogID/GIvgo2z+OUd7KSuiB0OkGZMuQm+l9wz8RBPhF0gtXjOkMc/yveOuMf3cyO7pA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oGGkaKuofrXYQgKDtboeHNIwCdlKo7jXoehLTMQaupPzifRZskFyWT4jpzV2tKTiUUHLs1PvKrqyDWK8i74RDcu8r58NshxNQgd0nDssXfZibbINRGF/Dre5LLWRsP8PG7zkPDV/SENWIR+o9rxTIjx5VjKXxko8OdT5OPFSkPqIthaMnSFrRUuzwL1An9lNm6yu0rlt/KpqhdRw3hZe1Fr4o/6Fp1xitYnKJNfaS8h+FfZVE/vg4yhTawXQwVbcpXEinhnQB8TUbdrNhbygnYkUWwl2eBIBi3OVqVvKh7UqbtPxMqY2tLVBNFUVPcS0Bbx7Qd48yGGiSktmyBEZdw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 18 Jul 2022 11:16:39 +0000
- Ironport-data: A9a23:Uy3AZK1xoYNrC85lSvbDix16xW+F8HFdZcB5hdg8jSJ0ofuS17OWlPgJJ2/OuNTVsDYEmuJDyr804BonUWBagGkjRIsJxkLyBgUPdBji8oJTg5IoOlONm5VAnqaa3fnrU9O+9hKmthIrSyPTmKRarOklrvCX3EtrcbbDs7Nly4JSzgDKJLhUv7kZ2gMOFjjsehPcIPlDr4N6qHZXCUtOmbhWtjjHZJBLw2Lm9tMLp+WPJE3hTJum6BafYImgaguqBKhnr8rRLeMAaTr825Ct1/dgvNC8klSwLa+XUPYnvMj+PgS7L1BJCeHZzXhfYX4z24erEFHSrFbwWanCJOoUU+29MXLRorzH4WwMQtB8FSw7oJ1bDN6ChWW9ntAECTv/Y9ABoDm39re/Sa5OMgu+j6xDTj1rO8cmSu7ymAhWZFcK7qwhAuUExkj5IttQXD0uolhgH8MkbbYXQ8p2A0R2A7/yuudydW4vqNs+/fEk1qm5TUcBTqhQgMoSnYz14cJaT3PA26Zgv5rI8Sd/y2VLyXX3y2lqMoq4scXjx/dDWge+gv8Yz68tmlVpbatgKhxMgvhIKPgRBngVnlOGZOsfJgExRY0Nb//PMS35AUHiUkvHLBhBvBfbh/waaynz7pvL6buTu5oZ+KB/gPg4kCzw9A69V567IX68sbxHfcMio7dHZRpg+PsCEVE2yAWmXd22AJbjsdjNrnNTGWZLMmsU4HwJIbOaLLgXN+oz/C/1UkAydnbGn4taHcbs6mFvhADbckjBzlvyi4MER6eRYk24mKqpJmSAhbCYgiAfmoh2sOyNjUHLPQ0KMKfJjT/DLNCFyDjbjfJOO0WzTuQWncxUSiwsWqNdB6WI7UyFkHdv/ttRRxnCRAreJ6/huss2ClWXOnC7qzScJx52t0Hn8bAzcsJ4P8qx1BkP5+4J8iisu4TSa+OcKV3l8VT0Q8s2ilEcIgRoZ5TljZZqk8mWVYW+ZbN0L8Ysq0WPvHUJ9RHFpmvYDaGqkGDqV7jIObD/0IJk3IvIW8m1hYJbAGtWqsgq5Y7eDZv6Q/NDHoPGLmAG8oefkLi8Ru1kIjFG5LtH2FftOh6Y5+qgMyBoogyc/rgeOkPOiiV3lAPinq+uOox0Qmhx38gAkSTrQfvNHEADKHnaFn94slp6nSGqvbrpSTYWg/6T1MFC+AypcBjquaYTfZMAsF5fcU10bfnyVkhxTfninikiJl0DxvllrLsrgvc7rvzmGFYZ0XohpR4aIDxWUmBfco61jq4e4zrBqCPpqoSR2TDpTGOEc46lk1e0XHh7YqT+zoWuiv/59VzAGx2IBZh8eK93BWxp0XeZjQryYrgXo6NfuPRelxfTfS7NKVyyaKxYz6ahcKQxKnX2xUQnhSanfu9vIaVshOXiQ7yTAQf1miRtDWfSUBjU86e2JZpkRiypjXM3BkzTAebpxFwZ//Kkg8MpyZd8ucIBWfmV0z6rSC81mjRyUb6/moBKHjQVD0BUb9kfr+GQRUHMhQcJitKkjoNeI2pYXEn7e1jwDtMxNEVB4TvAJn1VkoW8j0OJw1hjzsEWBCKkiFjfnJC8kda6hWiNHU/DvNnVtkeAso4A0RFdVYFDJfCDUDJWkqWLHnxs5QCXcFnHgeY//A3yj3yimWmdvp0bLeSsMU9Q5Bik8i6zcyYrUiSGCGpuDPdy/2+H9koaBvQABZPlafYixWqUqLxERPpdnjj+qC2P2KHVPBYP5KfpQ6LAYP1l6Ch+4MDnCPFfjHwJOh6Ri806IrZ/YY0KOq6WSW4N9CLnB7XFqQrnW7qoPRvUOMW4Ko7lNCIYZWVwTnYeCxVJ9XVZSpChR5bd/MXx8qRkESpQZTA70jDf+nLOwmunR50tnPYdXmOJjri3KPF4y+cJ+6mYTDyCL0IhBu4Oqr+HhZmer6t4ZdtyZMyJ3RtY5GQJuAQKu5De8w9tugNlIIXwcVeKYifdUSmZFiHCGCV9d8wQeVFogPmwSs5+BwV8MVIFvIEyHs1CE2pDCfz4A0F5v7APn9YMXxp8QamiA0NWqtmVYkJY+rc24yKeVR4JaYPD4tdDelaSxNpEleDRA5MjthQ4SQWcGbNrWk5nSucfR2lcocJTS0PhJoiCG4jddsIbMhoiiLMX0K16oRDswsOSptyUJQuRgLoCF07OIzytca5lbxx+VpTxa9zPvh5q5LVGl427vEl+wmqfjUAJ97kR4Pw3oyTFkmJc7OLY/qjeIIeS1F+pjfXGMTfI+qkbGHmcOXlK1T0sIxD0kmA47ZxX+0jczHGLDH9ElGslqogMH+7XFiDY2qhRsO/aV27a+ZmHQD7hxrEwaxbHS0XCu+m5fP9xPZq/1GAq7zI6uRF/iBvra+Bp57AVZFxCfU47GKGGGx3JV61ph3msS4EY9K5zovE84psjTKNoLJFjvtxculYW+Lb78OG4ef7aZ0DGosybxjQsrQdOChknTk6eam49Uf/3A08=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYmnajnVBD/nNGjUq8LNREqaX5Ha2D8tUAgAAH54A=
- Thread-topic: [PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT
On 18/07/2022 11:48, Jan Beulich wrote:
> On 18.07.2022 09:18, Andrew Cooper wrote:
>> With the waitqueue logic updated to not use an absolute stack pointer
>> reference, the vCPU can safely be resumed anywhere.
>>
>> Remove VCPU_AFFINITY_WAIT completely, getting rid of two domain crashes,
> I understand you mean two domain_crash() invocations here, but ...
>
>> and a
>> logical corner case where resetting the vcpu with an oustanding waitqueue
>> would crash the domain.
> ... some other domain crash here?
One of the two above. It's more that resetting (would have) broken the
affinity and would have triggered the domain crash.
>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> I assume you've checked thoroughly that calling code hasn't
> grown dependencies on execution coming back on the same CPU?
Urgh yes, my trivial test case didn't encounter it, but anything with an
smp_processor_id() stashed on the stack is going to end up unhappy.
I'm going to have to retract half this series. (I'll follow up on the
0/$N with the longer term plan to remove this mess).
~Andrew
|
