[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 18 Jul 2022 13:15:39 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xrzJzDDfQM8bY+LD7L7cRD1hqD7raNTDQ9IkFvLqrp4=; b=bXGWIgtvW+lFjyjYB8fov6uMXSVT7oypekNYDUB4cRKtLe877n2SDE5YqcEF0zKs1h9HNxgElJzErh0ql0s2SLxI8AUcl8TMIUypZvE+6wtvWWFvwfoTYtVu9t5Ap+8uqXrEA4ADvio4OEF4VPTjRp3bu5ojXRlwP35G0jrmu1V/XrVX2tSzDHFO3JBsqgolrsco6Z43E59ag4xf9u0nT4X+PiWQtR2ntSUXq4B0AnXIhwoR49WvfS6kbcgxQmGxcGXVBv0svO1hds9whvwDYRLIfuu4gBPCJCzz11NG0pfu0VoOpYSEcqmtVCw+dptIiG3+wsd+QI5EwB4QfK1kQQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PUggHbvSrTyBGEuD/wOSwf/OJFbpYlt3KxRcROzp3ZrlyuGrg5e8BB556QgzaMUAqt8Oh4J+TD7taFrqet7BEop1h7BzUJl/NI5XUtE9dgQQHXMIg6r6hH7wz7M5MwGnLIW8W/C35+J+LD6UtsKhVjmfCVB3A4ukYINT7B16kVUeinZiHgcyEfvtJYeKjbInD9d0dL5EF2qkC7IUTshOC8tZYsGUBLVdUJ+9z9H3OXfO7VilqPn1rPP/a2FgLnXaEQr9D94zgx+rPIY++YtC3o3nXFs33vxobmrMYomgrWl6pqOFLFFcr7JWUAFsAs3OOZHoU6CL/gYrkEiymqynbQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 18 Jul 2022 11:15:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.07.2022 13:03, Marek Marczykowski-Górecki wrote:
> On Thu, Jul 14, 2022 at 12:17:53PM +0200, Jan Beulich wrote:
>> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote:
>>> +};
>>> +static unsigned int __initdata nr_extra_reserved_ranges;
>>> +static struct extra_reserved_range __initdata 
>>> extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES];
>>
>> Overly long line.
> 
> I can't find what coding style dictate in such case. Should the second
> line be indented (and how much)?

I'd recommend

static struct extra_reserved_range __initdata
   extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES];

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.