[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Jul 2022 08:01:49 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JWtTCuPicoezP/G+P6t0Ki2TwDIoxh3zWYKsjWIG8wY=; b=haPytklIX+VfQy2mOwudqT/MmVxZVbFPct/BlIQ8iqAqJX6WmF4rUKVQHvqx4sAZGtLbVPZ8h4uH+YYIm44oT4fbdOHWiUMWt9uPADb/Fl1OUu0lpiK0hqyZ7JZvZrpDf/UBPJQF/caJ7B2p1k/YHjZ38uvE6HO5ZIYH6vBJEY/p6BBZg9UmEk5BH1XfHNwnWZOzfe2+HE93EZjrtWo0jXtmYJxq7a2HRqTTnuK+gFDBsKNz9+3aiLIwCy4CVLaRX48jiFLD/FUxOQtamtYT+Csul1QtPEYb+BRCDHJ4XG7WlMr09Af3ZCqHYucoH13N1CCvnuoOQbV7h5XRtRRRNg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VcmWj09X9hHaXFeTU73RgL03Dgu2Ftc/+DudZhd2pxPzeGSwMlbjxgce7+rbZxTDQOo4AnEmIAWdlm2hH/RF23jPqpIqnCPHnkUZT2X31MBxOXNLA+rXBVy2n2tKdwbSeq8X3SNeO4CqiYOSCgMquQmGsKOxXOl9CezrY/6DSeO14lFxSipCWfxMLPYemCzQ269vCeo6Nv9Ku+FnJ4X+HG7G9UOAnTGXWpJ1APVkB4+GZrJMGTLX/D1GQ6ew9d5poA+1WigRE6/ZPp/GDl0AydkJSijIoRaYyJeadlnWM9j6W3CIrp455sAjO6y5uqHDhRbeihSfih8fqAeMZZSPpg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Hongyan Xia <hongyxia@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Jul 2022 06:01:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.07.2022 19:39, Julien Grall wrote:
> On 18/07/2022 12:02, Jan Beulich wrote:
>> On 18.07.2022 12:24, Julien Grall wrote:
>> 3)
>> unsigned int inc_order = min(MAX_ORDER, flsl(e - s) - 1);
>>
>> if ( s )
>> inc_order = min(inc_order, ffsl(s) - 1U);
>
> I like this idea!
>
>>
>> No compilation issues to expect here, afaict.
>
> Correct, GCC is happy with this approach. Assuming there are no other
> comments, are you happy if I make the change on commit?
Sure - iirc I gave my R-b already.
Jan
|
