[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM


  • To: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 19 Jul 2022 08:07:43 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RQiFIUr281ETQgWNQUgPPgBy/1k1F/OjfygX0OKBCsE=; b=jqIcxH9HJm1dC6VzxQa/jgeqh5h6F4PUD0Ehsxzed7JDFPP7g3V43Nid/6gHOgO+iR4bLo6GMkcuX51EU0e4c1kxKfN4/AX8w4iL1JGacyoE9QtnMb8wha1jfNJ8uqjKx/PiulZ4mui2j5XnJ2uGR07cztiSR0WOfxVqtrYXMnT9vKQ+docHK59XtXAQCybvGsqgcweMhDKo/EPJ3JGhRtglmJEMi4jud6yghSDo0mW2Zj8fLM+VfiF5+8xtQzvu3AFAYs4eTzL4AMlVxFTMikCSo1JTdZ2WbAgkGyqggxIvsU88ZxxnwEv8oYt5hvGFGEd3dYgoI0jJDFbXwycK3g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GkV2uZaTgPKxF8AHDiZq8QsVvhAgErg8jXuCthJ3h3YMWKPqzgR3YgTuDic56kmfSL/SUlkxPdJLMgKCnfTDfDbMDrsxeTOMZgfd2qe4Md3CNET+YAsQ5f7QieTqD+rvHZYcnrlL2FOlgKsrL0gRBSGZX+5Dw31pg+wrXEg0bhzOEsShsCbY1an8iVyjk9U9i2appZ+1XTNvin5N1hT88QUyFWXlC6oGUtGpD2Lf3rDNIKExZardZNfaF14QzQT04l3UUxQniI9dxsVBbI1NM4C9l7pgS8nWAByYDgtYRis02vlE2mwKCidgMI5lWldJVtiNfTb0CMxZSgwHGZInEQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 19 Jul 2022 06:07:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.07.2022 23:15, Volodymyr Babchuk wrote:
> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
> iounmap(), but not added corresponding include.
> 
> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")

I don't think there's any active issue with the "missing" include:
That's only a problem once Arm has vPCI code enabled? In which
case I don't think a Fixes: tag is warranted.

> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

With Roger away and on the basis that I'm sure we won't mind the
change:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.