[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Tue, 19 Jul 2022 10:32:25 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BY2AUKfBxi9X7pJmjnwBZcV/H/f0NIH5eYvKnlU1nYE=; b=OBZrMQ1yzUQgMBuWoAepy5scmJDN2kwmjobXLq70j5JWeeYuoNqhUKrqrHW6Wk5WBl6a4f6DyQ5qjGxZL8xR5eXR3TI89wyhCV9kwg4An3l3YgsaloR1RJC+WrcpYem0lC41v6H9BXS70cvst01Z7XRtzBtJVwbwXtrKqiJmktHhR1JgXWIQqBS3UH8V0anyzPWnLlQClGG+nr+PeglSnjabSMYHNI6Di/eYhXIpe2thYPvutHnm2RqNfgfKHTT+Nv/VH9OHXhse6RyqrN9mR6vPoZSNwZwiSOCAU/Vu8aoe5brTlYCZ7/BrA1UoBEQV9ouMiOuodxkcKt34RI48HA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EqjqhUN6NZIMWs7cesoqNtyc016duieGA+OpXt/1BzygLNcH7puLWf0PxWlK4vFNtHezWgBWEEIfSEBCegeWrzynpvo6sdeDyc2KvNwT2V0YCmYGGv67nuf73Z0mH+PvDXlyO9wwy+azc6m1DQ/F8ljtBXFgJlVfWaNA12v9n9jQTdx/bRxvYRfs+6CkTLUU2MoC3wpgZpKCjgyPKM/zMGY1rET0HIYl6snoQ9iLyYZSeb3wSOZiVItUXJ1EBh4W9K8WULbsmK6N7qBSCMrr8xG3dsoPhuNC9YSrCxG7v4p9qJyMfYLjAMDjddUOqqg2+meTuG/VVlDe54xIRQMfCQ==
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 19 Jul 2022 10:32:44 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYmuuJ09LC1x/2uEWs942YY/fNVK2FNeCAgABJdQA=
  • Thread-topic: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM

Hello Jan,

Jan Beulich <jbeulich@xxxxxxxx> writes:

> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
>> iounmap(), but not added corresponding include.
>> 
>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
>
> I don't think there's any active issue with the "missing" include:
> That's only a problem once Arm has vPCI code enabled? In which
> case I don't think a Fixes: tag is warranted.
>

Fair enough. May I ask committer to drop this tag?

>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>
> With Roger away and on the basis that I'm sure we won't mind the
> change:
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thank you,

-- 
Volodymyr Babchuk at EPAM


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.