[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM
- To: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Jul 2022 12:40:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gRjwHYs/6+ulOWiNct/cBA7oHfv2XFfc84i8pr4DY4Y=; b=Q+MKDLAnMZ2lUZZuPSieiQG9laTec3Heg6L6FbrRPFxYEI3LSmWxpNauYe/16ckag0NR1zJPLOWKJWkC8Sel8xCYMhSSaLGRBrcwY7hsge52lDa3hOKvN3KzQ/IiKbNwL2cC2rXQUiUg5L527w7FxahG8Si9VuVpMmpJpWwpQHQe2S5nSevYl2GRwWfCknHCqZ201SWXPKeEcwrT98J+5MQAi3YemD/mbfynRf5Hygwo2V9D2oNC58td+CLieXFejr884Ze6JJg4ftZcJbfzNIHRlhwyVwRuZkV5AO96K1bl3TEhdxFszWSr28eUk7x28+8VORRrEwGHTo1SSINtBg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WoBxl18nmlFDs7diHv14QIe94PiteUQXz4poWylD0n/rthcbbzfQbSPLoRhj4mqRlhkfCbPa3DNLoZTtMFCGbEgxKXQsz5h7KSIk/QIhDl8wPmRkoUq6SyK3DbUkzJvRpcSKH/yL4/AOttniG6L+5gDu2hkRaGTr67JkCg//0ZLRRYGThWSZ+UfbRtlR/cu08Z+TGLNhLN+ik21Q5l7xnd6aOaR0onzx9RAY3xVrT8ZojFTWNQLcWTE7tMQifooA09WdH52XPfq8dLvyDjz4f94oKvKOG/Oa7JOJmjRH8urq1fZ+SoOEt9zvvTA0VFxnavCmLqte0khT5LGBt3LUbw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Jul 2022 10:40:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.07.2022 12:32, Volodymyr Babchuk wrote:
> Jan Beulich <jbeulich@xxxxxxxx> writes:
>
>> On 18.07.2022 23:15, Volodymyr Babchuk wrote:
>>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to
>>> iounmap(), but not added corresponding include.
>>>
>>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses")
>>
>> I don't think there's any active issue with the "missing" include:
>> That's only a problem once Arm has vPCI code enabled? In which
>> case I don't think a Fixes: tag is warranted.
>
> Fair enough. May I ask committer to drop this tag?
I had taken respective note already, in case I end up committing this.
But this is the last patch of the series, so I can only guess whether
it might be okay to go in ahead of the other three patches.
Jan
|
