[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 21 Jul 2022 08:09:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y4KRPOwIMQUqC1HWijP8a8T9I5aVXmuipJ+DoNxYCYM=; b=gV8Wdiej/1ymVj/eipM6cVnWA0ayTGtdwwUXndx5Eqsc/+CfKcZ44rqccHH2iMGOAblAYWu9Tqfh5Y0/jKZ3hl8HEsgpl/ZVz7SSgNMdBouJwuNQBo1sfnREuebiELW+ozlmqhhXdjV2nZaWYv3urfOwW+MGRJRW+RQBtXE0HTLxBBogdaVBNVPFhuWJCuQVu470mICwJikeVWlH3q3prz7NCQNC7udADn/KoAmcsuR4uOMdNMGjYyDTG0ozvqGUJ4cbrWC5XLOw8a7xpnPzp7YciD7IJSWLDltmJJQPTVW3dD61wPvJWZ2TehR9WPw93IMTkpOFR1Oy+jbFozodIQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y4KRPOwIMQUqC1HWijP8a8T9I5aVXmuipJ+DoNxYCYM=; b=ccyWkWZ0b1d7vVI3KJjFOgwCy3+y3MCPAri86ng0O7MMJwvz8pp68ia+Gns6N2MXXAp/CFHO9drP62vC0Ga7jfEoZmdOQjOBm7pgXd0naYxE6FEAoa7+lccBe4EOkMYJ/HcEaEPB93zUlrBoU0W1rF9pi+ThvAV4d+42s3dAMvQboqD8DqEsH6bUCxTxywdISutj2d8VlBzLUaQ7fiwuj0XvTx+ocW3cP3Xkb695MyqrV2jfZP9S+aszXdpm5NbwXZlyNurXJedFMzwoct4SAxXNQXQxvYYPNiFIMKkCVH8JJoCbW/8mRpygRS6eONmJJEt2NudJdg+kvMXMgJ3S/Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=csjK9Alq9VCZD8o0I7erzaSRqTrYmCvGc4QmbdWxdfA1gbvwdTFlHP3sRefLeBWt6eWu/pwjjJ/dYcbb25j5O33gnTNxF2gaPeNuiH5t2sOPWzNsSfcygkgQqsvO4EGgRbS4le+cQ/9nUZljfXejqm+NgCvRuaZk/ey7NKk1MEZeZfakycj9SzPOvXWU/ruOdy28ymiUUQOXufXwsrOLKFTpoCcZKA1Qymr28EwvLALog+SQX/S4rhpJmrQSGW7ymEeD2d6UtXD7dC3dhC5J//NEgHRYfbvk9F1jQPKE0vd8eh/mMmdboEcvvo1lmRafXnk8HSl/Uw+CghcrE8EWJA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gQUo6NS29a5jDH+NZQ0D6MDo62YT+mkyqfLz5uhwjg/L1GYpL3tBk4IN00B/xlzuYf4AsdLbk59bcsyaEZQx7EKuCsIC6aFZZOKJ6GoCfMpr6W/yMrTQY7kpE0Xb+qIReKGWBfiOsEbDvf4rhdsztFzfhF3dnMF6lUckX3vP4BrLqvtQUacNmRJES1Yq43rhEMfdHQ9EM+CCgPh7zJaQFsYiJhxmdxzkJdZievVcey98yWDON9dtDYS6GJ0CtwlwN1KYVM5h21l7vCdzdpSZekLFUH15BxDjRKY0wrvjuiaLUfR7k+HkWpkrdtxKCTIATwSa2dA4EXC1dAcENNniew==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Delivery-date: Thu, 21 Jul 2022 08:10:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYnGjbXBqTY5m6xUmloRrBtkUewK2IeZyA
- Thread-topic: [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines
HI Julien,
> On 20 Jul 2022, at 19:44, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> At the moment, *_VIRT_END may either point to the address after the end
> or the last address of the region.
>
> The lack of consistency make quite difficult to reason with them.
>
> Furthermore, there is a risk of overflow in the case where the address
> points past to the end. I am not aware of any cases, so this is only a
> latent bug.
>
> Start to solve the problem by removing all the *_VIRT_END exclusively used
> by the Arm code and add *_VIRT_SIZE when it is not present.
>
> Take the opportunity to rename BOOT_FDT_SLOT_SIZE to BOOT_FDT_VIRT_SIZE
> for better consistency and use _AT(vaddr_t, ).
>
> Also take the opportunity to fix the coding style of the comment touched
> in mm.c.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
|
