[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 21 Jul 2022 08:35:39 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fofCyzrORUdLScIptGph7XeCgcAnTIPNo8J8DG8sbkI=; b=a7OvFJNOAY2xJ8hdpscsT7FoZgLI3FLu3DPx4c/eNSwugwcPcEbOO5uBgsLwysOu9VnM/LK0Df9RQK+SVP8PLQdJhDhoGG1cqWpwUvfxlYILiZUN+Aiqy6gOB+Lm07qJ8A68I5cVMK3IcTSxEsWJAZQkW2qbwGbxQrJHWDqoVQ9mx14dGvl99qKGknXAx6e5mptz0+ztBi4bO+tN1Nl3LA0CvokzL7bQ/tuj44+z/0xTs/mEmiiumhMKnVJCMc6cEB6drfugv/mICMBlxcWekuIZMYuox7pvvH8CZUSruFCGYXA3qR9eiHpcoT1aSvzBhsm5LUgktSfvuaZmjREnoA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fofCyzrORUdLScIptGph7XeCgcAnTIPNo8J8DG8sbkI=; b=NtB3YaiFfFhzo23hpX8MsHBP9DLZCIonQQhn5pWNqpeNtDgfbiNIep++Bm6UwpMzT+sOCIsyzQYHE31Ws3s34C+Gciu1lw1jteZZpRZenLgc73p6WzY4jjR+0b1TTe6BBYXY4hlvqadyKS6/ugNPLfKyu+CVMYm8Vb4YaK4xexsttglLMQXVZnGw6Jc05O5OCuH9jKUKOWbThapZKvvUjwrVxaiRETP+xRVtA/aqIJe4MJafzIW1bumqQmBotjfp4SfWoDF8pgQvKAfP+RJdTVkctFq+FQyFuZzmCuNgzdJz61kM6kjE6BaFEKlO/n4VGUX7zQLWSbK1j/8NeEaQpg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aPQBIw9UOdZ/era49AGXhTZnSBPDGa/VFGDXTNkPpQNWMsd9H1Fy76sHXxgzbeLKOPFMksWO5CHbkVydS7oQ5pwbl3OOS7ik7mvmLtLalIYeG0gEqzXzu8/j4zhgIsj/ku4Lakqx+Zvyotvjed8h5/ZWdOy47/JoLDsqc6tWoOMBrC+yIlpbqGciEO0M5MHAsRqy8+IIGfaYwYfd2N6QgYuOvq/9DzZCW4mk6hy8jVersQhxO/brYTtfSmiPTvT92F9F2QtnQmsqzumvi4ofgLtGu4ToA0K+qKaRTw1hLDG7lWjk8HZNeo7sl3OOYkoL8PAGdmc1WA3F3tsC+MnH6Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKZX9F1XgJjaz9ztmrOLIAzdUBE907v5IHFD97jmkc/l6TUdnSWM+WgG/Ioy2aT6uCaJ2yt5lARlP0wJc8tHurugwACi4Kgw4TWVsTQrAW6rR2mFWDXYuvp9+fqd2PY6qeHlIUca0dUOlHTjONIxP73chrhuE3xMgGuMSJD7yyJi7CciGl1xpU65DtgAnbyYpM34v5d0rNRXZkKAirFw9UDQZXCtYTuc+pfnycLGmFYh/i37VjSoYzdYGV9kRcdEFXlogShq7LmynBNRQpUea0D1eqwKXDZ9y3GovOd2CEHC62lcPv0SUUEAoJ3Rpt4diIsUtRLBA7TcyD2oIu+ltg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen development discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Delivery-date: Thu, 21 Jul 2022 08:36:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYnGjlp6U2YulxrUmlrCnvJIWo3q2IgOKA
- Thread-topic: [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines
> On 20 Jul 2022, at 19:44, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> At the moment, *_VIRT_END may either point to the address after the end
> or the last address of the region.
>
> The lack of consistency make quite difficult to reason with them.
>
> Furthermore, there is a risk of overflow in the case where the address
> points past to the end. I am not aware of any cases, so this is only a
> latent bug.
>
> Start to solve the problem by removing all the *_VIRT_END exclusively used
> by the Arm code and add *_VIRT_SIZE when it is not present.
>
> Take the opportunity to rename BOOT_FDT_SLOT_SIZE to BOOT_FDT_VIRT_SIZE
> for better consistency and use _AT(vaddr_t, ).
>
> Also take the opportunity to fix the coding style of the comment touched
> in mm.c.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>
Hi Julien,
It look good to me,
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
I’ve also tested on fvp, starting Dom0 and few guests
Tested-By: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
