[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 10/25] tools/xentop: rework makefile
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 22 Jul 2022 13:13:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wErP77+PBFHHrVpdVOfdqP3+il67j2XJK8wRT0Uiu14=; b=H6ctCwGiqNZDfqhv5hkYArTe3mdTNCKx5/KP2Gons42r8dRMaJmduz96SJ9deP88gDNIrKCZhFUqfPIdDxkzSVbAszFK/fANBSNxLoBjb385+IjOejanvMRvxEHkQIvl5Y7yAzBAPRE91wUkCExcwE79tUu2Nn3T3p9zpikVuxlx+hzpcSZAMJ3UHeqBCuQjhvM3DaGtFdWbsyO18lTrwxl9Xad3PAvJOSNM5QeFn6bFcqBMUJsUQcn/1gSQhG4aSuNjmG+teWIVhNz9Orcru8CnVv48zcADxtmaNvun3z35/5KaZ928o6DKJfZLvVJlkLdXOfYqmRK+hweKb26aTw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wErP77+PBFHHrVpdVOfdqP3+il67j2XJK8wRT0Uiu14=; b=TZHHaGBx0giL5z9RZSpDkFhuuZpfD2UrLiRXSlS4egFtFenEfN9kTLOom5AqCrSk8LZMcNuaygYhTaySGfnryn/7Cy6GCOcL00NmxJQJ2B0KSCROl4+0WLN6PynBpRGmVGXWXG7b8mn/l4pPEkES4OE0SngJZZq8Gll6XKsVNYiAodgW9oPmMUBrhSLLciioMCEyT5KUwga2BhcRXgVGq1/t0IHPRO0fCsyqLpJXS/2qxO7joBrudc5ADK5M5y5eWCRwcWassq6JKD8DqpLTejgQXMSz+KYN4PpGZGILHK7hRa0NWGd1z1xj4XbxPyIMt/Gfx6F5EBmD3OHObfp1KA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=T0NNu8dxGAvRuaxwxdHl3T89YwPq/w0ChX5xVZwfLX8wm9tfSThqN9dcg6DCcd52MlBMuZ86YlPFHtjx3rgtqCNfqZBbr5N/4RZRFU1YA36vF7oXjl4Yu6vkfhf6wQ51CH/ojp5tP8j34HJX3d1uUvX/P80DxaEViPrcxxK2ESdzoRqmTwc/VeZAVHgJ2wq5x9zlG71YwKj/tBsueebBHvRoswnb1tKUMGbvizVeWUiWuD3LQPB4qKdaQ1RJgXPapiKp1cq1ru8mTfG/g5Yiw2rIejuKuIL+DdUE4JWqcwKy1Kf1OWSR2YPowV+5oblg3ft5AJ99/hexo6O3cuAiiQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nreUMO6KLmWrKGIJRtg73ypmgS8919OQm7uAdt+7aMWhjEFppNdm3KId5h3io/hJbKQQzBI2CRJhQpUdTm15hp+dogyUSzxi0eqL6umR79os8jVBF3n905vbSrZrNt9ekoyH3Vlc9WejzFhrjONR3/EOtVfFQQyIFJ79c91TdBLF1eU8CPKjr20Cxim0zrayQ2IfjAmXC7nBsnXH0G9+vlvV7yHh5sMnXgqRiWdO3PccSr+oRZQHSYr22cm1aWzJRZAVXiF7V7B8ASBJyguZPWdqgFdIYbjlsRNNrRy/mN+H31beTjJoFW7bGV34ip4kdrec7HIitTZMuQw7BOsb/g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 22 Jul 2022 13:14:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+Q1KLXT6Xly3keDEoxcgJ3CFK2Kie8A
- Thread-topic: [XEN PATCH v3 10/25] tools/xentop: rework makefile
> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> Add "xentop" to "TARGETS" because this variable will be useful later.
>
> Always define all the targets, even when configured with
> --disable-monitor, instead don't visit the subdirectory.
> This mean xentop/ isn't visited anymore during "make clean" that's how
> most other subdirs in the tools/ works.
>
> Also add missing "xentop" rules. It only works without it because we
> still have make's built-ins rules and variables, but fix this to not
> have to rely on them.
>
> Use $(TARGETS) with $(INSTALL_PROG), and thus install into the
> directory rather than spelling the program name.
>
> In the "clean" rule, use $(RM) and remove all "*.o" instead of just
> one object.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> —
Hi Antony,
Nice, this does it with just one gcc invocation.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|