[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 11/25] tools/xentrace: rework Makefile
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 22 Jul 2022 13:30:53 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7m+r0zQRXv2eZ9CJuxVVAYbBlzcpeQOKcOjAw8RSvnQ=; b=F52/GIn+QS7P387/xFjDHIM5RHQj0z/9NHjA36XWwZ25ypiQly5Z4qyQoA+slAYGQzokDe3EOIk8YxMA8ZvIajXJEM67qf05jzqWY6Cpb97XZ0N8V/X02bBJsmZ7Hcq1MP8UUJik9t/SFO0e0RzZbNNMDpNK0+e8QbtD8DgVNBx2E7+qHZS0abVdsO/QETjgMNgfvud2XZnVlI3EhSswzbf4mr9Vq9vRWbgHBIFvRIxhCgXParCXFcfPUvhq2oiKJuvJKi6CNhNKedtz/F5uqxxVcz8fKGCNiFd2ht5/Jfq8z69pa8z5uy0tohUf75fo4Q1ymT4RJQWhstk8jJLxZA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7m+r0zQRXv2eZ9CJuxVVAYbBlzcpeQOKcOjAw8RSvnQ=; b=YHNj0NQyD3qqXNQamGOIUM0k33lF4WiWVKlLGz+OT73sw1pNr5dmjuiWYaJ2ttYqaarollKmRpDtttBPuSvD4Jij/Wctv7R76Mxy+tZisRuqAtjx1OACjFMN3T2zfiilcJlthNeeMR3jx4a3md4tQ8ZRzveX/QqOJPDQb6egBzFT6C++M7KEyed6pYAcGjgTFI+eFi4hC2YeI2t/6ucDAA28Z7ExBVtXo0dKwxe7BiYDj0kL7CmQnQtgfeFX3Wv06jWNuBSfhH3gYRIHrZa0bJ49jtHGOQaCKT9NiYc+p7wVJ0niocFuTrdwJFKSjmNEqa9Yx4w3pT2ZRMXymckVvg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LQbYPfHP+Oi13Ae7rxfq4kAW3WsBVD3y++abE46dONG9s6KZrn0dkt/Ma+O/YTj/KHr5xfTCMRGAd81H/pW3EAKPlmNcdm0i9pHpr+fuOX7qETvQIDS/0HODNj47TR0u9TYleeTTDTSLIBdDPqWojf4p6OJxrVWy/AHrasRBEyVNjlu+zBSLNa+1Ig2Jo/6s5eMGO9cmsR5uRGbPhsmMJOiMUCsZocU+XptG4dSdaUmZ4olY34itXbf19YWSHgvip283JWsuEYsEnVGUUBKs+0zT0GDO6gQdHbkprV3VNngQJ7qfEwjxE0V/Pv77oeZSV6js4i6xK4thhhP295jg2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W0+amNtTOQZu2Pvth5j07a9xSMkfvwe+jZOSknJu4y+T5SJ8xzFDepn12C/BdmTAVyQw91cGIqI8UEbeky84LSAKuRN4ui/E5+2FgsYYUljgCb76aB/7eERDPJxwyjmSIDM6JqDp2dN8GzzaBJ5XkVDSgQskkLgP62O/kVUdV8KOon5uJ6EWuvXZjZWY7RgcJnKd4cftLKrSvzJHmEdMsaaXBprZIOTI88ybKDrvDTzyHnlvAncIbaowamusMA+mlZGIXkCZvRVvEY/TazUE/UvQ+lpTwaJLi+lMnW5X51CenS7Y8vuvJi3x9F8n7uwjZdeaaXQJ4KE72sMFfqDYOg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 22 Jul 2022 13:31:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+S+xJXhWYMyUkSO+GQKLe3BdK2Kjr0A
- Thread-topic: [XEN PATCH v3 11/25] tools/xentrace: rework Makefile
> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> Remove "build" targets.
>
> Use "$(TARGETS)" to list binary to be built.
>
> Cleanup "clean" rule.
>
> Also drop conditional install of $(BIN) and $(LIBBIN) as those two
> variables are now always populated.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Hi Antony,
Would it make sense to use := instead of =, for BIN, SBIN, LIBBIN, SCRIPTS?
> ---
>
> Notes:
> v2:
> - fix typo in title
> - drop conditional install of $(BIN) and $(LIBBIN)
>
> tools/xentrace/Makefile | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile
> index 9fb7fc96e7..0995fa9203 100644
> --- a/tools/xentrace/Makefile
> +++ b/tools/xentrace/Makefile
> @@ -14,36 +14,31 @@ SBIN = xentrace xentrace_setsize
> LIBBIN = xenctx
> SCRIPTS = xentrace_format
>
> -.PHONY: all
> -all: build
> +TARGETS := $(BIN) $(SBIN) $(LIBBIN)
>
> -.PHONY: build
> -build: $(BIN) $(SBIN) $(LIBBIN)
> +.PHONY: all
> +all: $(TARGETS)
>
> .PHONY: install
> -install: build
> +install: all
> $(INSTALL_DIR) $(DESTDIR)$(bindir)
> $(INSTALL_DIR) $(DESTDIR)$(sbindir)
> - [ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> -ifneq ($(BIN),)
> + $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> $(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)
> -endif
> $(INSTALL_PROG) $(SBIN) $(DESTDIR)$(sbindir)
> $(INSTALL_PYTHON_PROG) $(SCRIPTS) $(DESTDIR)$(bindir)
> - [ -z "$(LIBBIN)" ] || $(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(LIBEXEC_BIN)
> + $(INSTALL_PROG) $(LIBBIN) $(DESTDIR)$(LIBEXEC_BIN)
>
> .PHONY: uninstall
> uninstall:
> rm -f $(addprefix $(DESTDIR)$(LIBEXEC_BIN)/, $(LIBBIN))
> rm -f $(addprefix $(DESTDIR)$(bindir)/, $(SCRIPTS))
> rm -f $(addprefix $(DESTDIR)$(sbindir)/, $(SBIN))
> -ifneq ($(BIN),)
> rm -f $(addprefix $(DESTDIR)$(bindir)/, $(BIN))
> -endif
Why here don’t we use $(RM) ?
|
