[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and...
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 25 Jul 2022 17:51:08 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RY3QNhx7VpzFe+yo2jhRa4wL68B+R3JENc19j9hx+1M=; b=Xl65RQ/n9Wo70Ed13Cz02AJw1qZtbAIx6VAmnl5LSED0CqUAPZbQVTOUc3tZ3xasn+VwdNTi+d9mi5t76bHIEA5/MqZkMlVUEEpBHmObbA+GBfV/TfdfXD7uP1lPOLJLGnHsK1OyuSSL9Lpm1/RwCqwXBxM/VM+9lyJVLfTQsC1vpuuVgLV3dAvKEDSP6oG5PKvRIUxjlSBEbH5gIbjI/qL90lxOQLVjnmM6wOR+HVcAjdhEnpu6q11QPK0jHqU3X7JheGvchmvvkoGL7Q0DPB9QQ+P1mSj93SrSwh11BVDantFnmydOj/QuFPP0ptjg860pCanA/hCzeIg4o2IHUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1kIGimLJ0RVj08ry9lciV+2tMKih4we+f4I9w5hMmjUJpFLrh+aVq9wzxHGBAUJEKIZmI0sHhgkvIaJxvCzjX8qb+fPTpSVapgw6lanMsWObK3sceLB4sM94Il6GKLLipDy1ikmU8nVXTPj9sruE2syS/5o5fL/Wqt9Cx2Aeze247wwJSa9dgW/fMez72U2OxZ6PbzE/Dt69sSSjwvhdkDqeBU4pM2b3X0nhTAcWX8t8sA2av8vTujhDKWTwrBoB7KrP7K1tRLHQQ5L5+w2Tl00+dGs9crHctIAyTT6cQXYiEXjJFS+uSDBLb3Pf+7Oh0dlnIdqKJ90/522zlTjxw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 25 Jul 2022 15:51:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.07.2022 20:44, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> move it to Kconfig.
>
> The define CONFIG_DOMAIN_PAGE indicates whether the architecture provide
> helpers to map/unmap a domain page. Rename it to the define to
> CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that this will not remove
> support for domain page (this is not a concept that Xen can't get
> away with).
Especially the part in parentheses reads odd, if not backwards.
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -371,7 +371,7 @@ void clear_fixmap(unsigned int map)
> BUG_ON(res != 0);
> }
>
> -#ifdef CONFIG_DOMAIN_PAGE
> +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE
> /*
> * Prepare the area that will be used to map domheap pages. They are
> * mapped in 2MB chunks, so we need to allocate the page-tables up to
What about the other #ifdef in build_assertions()? With that also
converted (and preferably with the description adjusted)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
