Re: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and...

[Julien Grall <julien@xxxxxxx>]

On 21/07/2022 09:40, Bertrand Marquis wrote:
> Hi Julien,
Hi Bertrand,

> > On 20 Jul 2022, at 19:44, Julien Grall <julien@xxxxxxx> wrote:
> >
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > move it to Kconfig.
> >
> > The define CONFIG_DOMAIN_PAGE indicates whether the architecture provide
> > helpers to map/unmap a domain page. Rename it to the define to
> Maybe “the define to” can be removed in this sentence or it needs some 
> rephrasing.
I have removed "the define to".

> > CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that this will not remove
> > support for domain page (this is not a concept that Xen can't get
> > away with).
> >
> > Take the opportunity to move CONFIG_MAP_DOMAIN_PAGE to Kconfig as this
> > will soon be necessary to use it in the Makefile.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> With this fixed:
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx> #arm part
Thanks!

Cheers,

--
Julien Grall