[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/vpmu: Fix build following vmfork addition
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 26 Jul 2022 15:48:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VK5J5IzrYvn7bVXSB1rdr68VYrfB8cOrDPtRDJ56ziY=; b=JDAHLQWcrtjYsysl6+6RZSqi/vkYc1d4QAGLh1vNjguUKUgopFcfdnjO2zzAWM+v4NMB+4VPjqyQAwy8ASzWQv+dpgIzf66dT6VDiusSq83CwUyLvSZbvoIlh0iY8VqY+1nxNslje+stX4nnmld8P6WN7SZllOhTjMBo2Y5Ji2zlEJslA/vxnpqEk30RtviMwgxthEEObaYOTQNYamiqI2UB43MrHp8S9HjPoQM5pzX7zh2GO8IN98shxpdXiEjyOy2e7U3xmcVdL5Y7ZEX7xCRMyqRGT2t4IXsytcjPvmJQJpXfLzQ5PAKSwMiX415KiOGpv0G1WJItBaOLCkI/lQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGHVNSz/z+p6MLmyfbpjOC6zbM0yk8RXe+rtMtJ3PyjpXMScXYKbXU7F6coyJJSieifBJlvhmz24Df921iKEtWNKeZzhOgCStoFrOzMwyXY1Vm9I/zTLWqTh8uqLG3owQglZE08f0d62oMIbrbuJ/JGFO9c3BvXs/98TZ7pACaClcbO/3wu3rrZs38JGKAaDW5jHRuBHEzBMX6VxfFUX1/z1t7zyAP7GKT9zlVgnP+6GnMRkDWfLbMrpO3KczF8t9k2y/8IrHhTb0lrNa/CvSmON1v2l5EvLHmOeWt0W1PLHFgqrdVtKSz/50QEn81/ikLsNFhynP4WIufclrDlktA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 26 Jul 2022 13:48:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.07.2022 15:13, Andrew Cooper wrote:
> GCC complains:
>
> arch/x86/cpu/vpmu.c:351:15: error: conflicting types for 'vpmu_save_force';
> have 'void(void *)' with implied 'nocf_check' attribute
> 351 | void cf_check vpmu_save_force(void *arg)
> | ^~~~~~~~~~~~~~~
> In file included from ./arch/x86/include/asm/domain.h:10,
> from ./include/xen/domain.h:8,
> from ./include/xen/sched.h:11,
> from ./include/xen/event.h:12,
> from arch/x86/cpu/vpmu.c:23:
> ./arch/x86/include/asm/vpmu.h:117:6: note: previous declaration of
> 'vpmu_save_force' with type 'void(void *)'
> 117 | void vpmu_save_force(void *arg);
> | ^~~~~~~~~~~~~~~
>
> Adjust the declaraion.
>
> Fixes: 755087eb9b10 ("xen/mem_sharing: support forks with active vPMU state")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Maybe worth mentioning that is is a non-default gcc?
Jan
|
