[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/tboot: Drop mfn_in_guarded_stack()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 26 Jul 2022 16:07:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HtkIvKUFpUIzCJWUNG3vj5IkWmPNXnF1JPbQ5cZR1ig=; b=RaiOOgcBypuUqLnrnwodFhcLFSQLN2eT7aGATLOoQt88HKK/teCb3Y/t+pjp3HWEMQRNin0rVJvvvPtdP3bmRmklryNrtM4evp3prLGVSHZKt/Kvoar6bWr2igNcifryBLKK/V5WYdl0Hjrs/h4+SQNm3HKUwNaT5ZHkenmWKLO2+prhudV/jA5GPS+m+uAUbmxqHkt4IEvRHQKX13eX/eLQ+Z2kmuiGaZj8OuatlONn6Umy5iLliuP39gHkArWBYLs5ovJHmRfkXgMtwCewU/eQuIIs2BROyxkeyAnQAx7Eb9sVwOXRHL22OjSazCdekrpgLjyV5b1kTPw9m1GpGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=adJStU0tLH5qmVz3ZhMRM0tAkKcE9dd4tUs9v8Lk8hb3ARax2xCOFPt8VCmhFDPrDgEgjTpyNFFbwMXnELB80JvwrHtxq45q7YaQgihU8h19GCfUnZc7FdpO5vW7ywu4lz3i5omhuMN9NTh6OL3Fr8mYjm13KjD8Pib6X++dn8xhYExib0XJjRcCNPfDZAwFUj75fzvRyb+FKLbYkysvVXTFAWTfgOjmYAKOmPAyEfAXP7vUnWgJG1GK+w8ykrgsc/Ti+ySSR38O5XMUmt2b9c1lQWUAjQx0EzmJFsbkWHNR4W9l5OzyIZQOxxQa2kbobV86XQBXdVRW01sCwT543w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 26 Jul 2022 14:08:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.07.2022 14:25, Andrew Cooper wrote:
> To support CET Shadow Stacks, guard pages changed from being holes to being
> read-only. As such, they can be read.
>
> Moreover, they should be included in the integrity check.
As long as they're non-present mappings, I don't think they should be
included here, so - not being a native speaker - I'm not sure about
"moreover".
> Fixes: 60016604739b ("x86/shstk: Rework the stack layout to support shadow
> stacks")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
You should have included the three TXT reviewers: I would have been
curious who, if anyone, would actually have responded.
Jan
|
