[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices
- To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Tue, 26 Jul 2022 15:09:58 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SBSjKsQeYHjf8o02HUbbhuAyN3XwGnAXi1WwZGf5xd4=; b=YDDnI5+T1a/Cmjl3s0lpcr9DzJPJxZdLaHAA0YEps4K1EQ8VtNkbJ1F6BJkpFpnNtLfkYRZvG4YQXY2B0s1X/mPfnUobW0bwtcGwp5JVV+Unxrx1ExIztTvfsUg+WHFk16D8SiRbc1OWi70kkD0IH6tOe4czLxrmofd0hqjKeanVFPgWJpPAVCimQ62o/rWVohxjgxyWHpYWtMr1vMSPhpS66L9yEYKYZtxcE4jKdKvGS7mwMlVev9LYNzIG6sOFv+hUrXINwF9KzOKX/oUHJ36Nl+5j/ywOqXIEQZ6Q6m9RvW8+e6Jhdq/3IDk6J/LYkbnu7QljdpGbctsGD2ww+g==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SBSjKsQeYHjf8o02HUbbhuAyN3XwGnAXi1WwZGf5xd4=; b=b0Zbh7jZ41eSJZ21HWikDD+k+7fSUp99zNYB3Qx68IpdTxucAQP3UANLPJwRXJfLFyIrx8d7kIWg/fgS0YNoEzYCOF9b+JFnvjYKn+kOlDuWgP10PMboXneaF1u3qYwvzD9WHyI5ixh91K/FRCINivAgf8lz8bAeWZSAp9YToZxaqaOQ2i3C+acT8cz/iyFdKvPFj+Db1tDVxpVMyTNOR3w9E9mfIMsN4RWTeZsk0g0rD4PODe9IQz4/u6PvlifcXUv2wrUCb7xmCT0B4xGCaGpah3+FO+9srSGvxaBmb0jUXJ5TjRxlbg4i3Rm35HpJ9tW3nMlmTDp2DFuMw3osXA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Rwd+dgJvHu884DWt66eNozibCGOO9skRSjMP6PrI72osjxVDmlaECxpVEviwdVwuATu2uZxnUDFcsJOfJqY6NyfHhYcXAWynpemLodXls5ZVZmVa5FsbeNyWHD9GMwvNOKy1+vuDvH9CZWEdFUmtI0L2a1J87qjCCUWFCTEZyLkR0zbOWiCp+TJhVlCjpW/9R9aqMkJ6KBtn3u+bXovsWdDP1jjUJSt8oKJGTdbOSkN0emd2xKSDUjfnVFiHQYCY7ujCWpvl1wjkfe1CTrCmcEmUNirASsq0qsacKpjn6M9+Jw7d5kLDnA25S8mlrwtoD/cNhDPsGNO/GgzBFl+R+A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7XP6k5u3JdMmRljeGQV0pxX4jTqAVYk7LDDT1AOS0z+kLmz5Di9xtpvfdbp2lv1gxl50N8tmYbO/i1uXtXFQc411V/VWgpBNHr4tjx6DchI0iyvCsNZe65A51b570EhcItkUdNv76jXvlK1bXCOagdJWdN+FW4OnBcN6ez0U5FRE+B/1vXQORrmbhKnfnjFPtJzIcjTU3R2XesUXs+oCZyIwgFxtpluaN8SKgagS/ZPUXi86/NDhPenP7odY647c8K0G9dnpxCy3u4l+kUKW7UhZyTMjtLTpM64TlkeYGllGpDrfRTi+aOTyr1sSCvj/Qwq1tfaEqZJEpYOV0yNnA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 26 Jul 2022 15:10:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYm5cRehGtwJp7b0+IIGYzLnlX7a2QzFsA
- Thread-topic: [PATCH V7 08/11] vpci/header: reset the command register when adding devices
HI Oleksandr,
> On 19 Jul 2022, at 6:42 pm, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx> wrote:
>
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>
> Reset the command register when assigning a PCI device to a guest:
> according to the PCI spec the PCI_COMMAND register is typically all 0's
> after reset, but this might not be true for the guest as it needs
> to respect host's settings.
> For that reason, do not write 0 to the PCI_COMMAND register directly,
> but go through the corresponding emulation layer (cmd_write), which
> will take care about the actual bits written.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
Regards,
Rahul
|
