[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices


  • To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 26 Jul 2022 17:23:56 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M7p2iaxgDH0aR8FX+tXM1Fvf5NfQywoIgZP+Tf3sW8k=; b=YS/wrwhh0X6uTpmWoK4H/ZleKweslFSCObbO5NY0Tuvwddfvj5YJIEqHbY7EILqHle1bMpvpwJGigbP7iP1S/VAvWfr0DnJShi2fdbdZ+ahmHp2tK+NlfXTXMqGoziq0lt2HnLU4BzoDvUBI0LicLSCqYU+ACQoBi3n6/AB8sMpwHogI526SGeFqAkbMeBPYsJRTBWCsRHN5jVOH3TZ72WDb+E63jVe+93gKHQ2PV0ui03OMCce53B/WZGT0p7wU//tc+sdMNg3vGmOuTPmT0iUvug+WwgGlZROHBmPgBYAPhEhNSGVORAluzX2FNAX1Rwmn2eQT4Xy4gsn1L7WZ/Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d95E6FHnWXCAImAxvtU/qRh1X7ee7iMP4RTngXInGrK5irX7iEPdFcSplchDYzvOzCQ4h4A6HhvO++1BJ3Mxz2FNNbqg3iQ8m1fCRgRriMzxQHw7uDKUW8lyL1iV9E/jjhBU6PhYGQv1vqAF5SNJpXECdfQuk3SXNeDMG8YpHuBFowGrpU0w788qVMU+EZJNIXegvhDzwal/T30uft5JPPFRuSqAUGxDqD5+X3VWogaSX8H3+3JNIpzLS8PpuSnp04eKI+TsA8coQbrJRA5uQobm/ysVKwyb8PCuxZu8YPgXgTgDnshMZeqsPvkriDlDmEUpVFVBtT7ggiHQ/22ZdQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 26 Jul 2022 15:24:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.07.2022 19:42, Oleksandr Tyshchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> 
> Reset the command register when assigning a PCI device to a guest:
> according to the PCI spec the PCI_COMMAND register is typically all 0's
> after reset, but this might not be true for the guest as it needs
> to respect host's settings.
> For that reason, do not write 0 to the PCI_COMMAND register directly,
> but go through the corresponding emulation layer (cmd_write), which
> will take care about the actual bits written.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> ---
> Since v6:
> - use cmd_write directly without introducing emulate_cmd_reg
> - update commit message with more description on all 0's in PCI_COMMAND

I agree with the change, but it's imo enough that you also need to sign
off on the patch (and this likely also applies elsewhere in the series).

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.