[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices
- To: Oleksandr <olekstysh@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 27 Jul 2022 11:46:26 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Xt5HD5Ukv10fyymRJ5SNLoHRutJlWLCUTfphG9cX24=; b=hBm5gFDkeqGhBmffuQ3/dFGfXMYNUtZX5G5AEHdIV/LzxE/5QsYZyBvBXe/vnuCh5/k/EycUk2EKMpC61OqsHmZJcOeJ+Fi7RDFmQoZwZyvxqL0R+2nHyM/kh7Kie6MjWFrejhdv21gsuw+fj1+USC8VxEcrfqPKzUG9zwjtSJj/Y085ty30WOXEad09nZ1JDgdVLXSwfRdNlKTzjCxPMXcr3b/HaAJVtX2xIdSh1lagSKcqYrscwh9oMPqETG2A7alKe0pGk1b2eSAQcJWU3s6+2cCGLrO4P1sfhOHV7xaxYD9ClROl2wd3GziLjbVN5JW3VGkFlWOK4CznN9Ip2w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jy43txEGITCCYPiwniR6t1Ln2fQ+LKC2dQa38N7ClvL1KQCW1tc5XW3jZFCInv5pnMjaVebuXO0aU3Its9LJUyxf3cCXGxHWdGKbDqY2hGswJCj41E/1ud01VccbbB754ECg3TDGKXwxhHxS+OgU1yY2np7WHmzKREq/5txMBuyDqwVWFMvxp0Ioe0BTRdTUpl1kJCiL8odiJwWC3wGuh0WpzsBNRRz5FdyWgzCQP1LY643Y6v54amyT6EMtfHWghgbItGy3jXtYWvM3kIpLmr5QzcrjbS3gp4jvibIU8T3vlkFhoF1a1CBAWcn3Ij47Dt/J3TXhcHNzdMgAD5isAg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 27 Jul 2022 09:46:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.07.2022 10:58, Oleksandr wrote:
> On 26.07.22 18:23, Jan Beulich wrote:
>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>
>>> Reset the command register when assigning a PCI device to a guest:
>>> according to the PCI spec the PCI_COMMAND register is typically all 0's
>>> after reset, but this might not be true for the guest as it needs
>>> to respect host's settings.
>>> For that reason, do not write 0 to the PCI_COMMAND register directly,
>>> but go through the corresponding emulation layer (cmd_write), which
>>> will take care about the actual bits written.
>>>
>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>> ---
>>> Since v6:
>>> - use cmd_write directly without introducing emulate_cmd_reg
>>> - update commit message with more description on all 0's in PCI_COMMAND
>> I agree with the change,
>
> thanks, may I please ask can this be converted to some tag?
I could offer a R-b, but you've got one from Rahul already, so mine
won't buy you anything further. What you will need is a maintainer
ack, which imo isn't a priority since this is only patch 8 in a
series which itself depends on a further series likely continuing
to be controversial (didn't get there yet).
Jan
|
