[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view


  • To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 27 Jul 2022 12:19:33 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hSLipPpo2w+945nQ/m68bLTaXDY/ElVjdIGuB9QCK8Y=; b=COSRjL1k24iskyV+1+sIqQ5HxCfvVpquk25BDbq8YxWcGonBaZg08jFPhE8W3XKSIVAv0XmvCwKB2YUJQCSuzfNyn2IZgmN9SwjggWk3ixaUNVoam9lL1i22ZNOqkmuwRom0S213DF7aw2gQZ7JEK00/ZMifkmLBUKmCPRSxiMyggctge0U7pPTXFh9cwCe7VITqAEpoxJ5Fi8QhOD3vBmCMYVFsa28WEJgH/4xqqRZ5KjFaNwgTxACzCih2E6TRGP2rQIEHrN2uQLhS/lUeZauk9Xhsb6bwclz6/NefcUNoE0vErYIAG7QFQfjpnzoc9XVkaBf1AT4n/NdIhHfh+Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ebVK4gnVysKCVll73kDc4IQgLEmgUmizR+bohzZmWSKSwIY+ztylQXwbtRBsPpFG5AKohvhB2magSSWXT4NJHOgyd39nTgkGbnZ3w3esIoFHHAbTcOObnIId5yUvj1xWuJBT/dYnv7iJKSOMFBZzxUWCYuK44RNi93wCabzuLcCjzviQaNxTCDldfKhWSmYQESfnSTeLy9UexYz8txa+//L9bWtVLbZKKIuE97JhvOTPJzVP9rVz4a8Yzpi8ILvFWkpyg8wChDMSxOTuAtrfTgVLxatJ0GWjAtFQqVGCY5N04AScccXPkK0Hf+lRy4gbeIgpTNbyTX73dGezxxPmqQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 27 Jul 2022 10:19:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.07.2022 19:42, Oleksandr Tyshchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> 
> Take into account guest's BAR view and program its p2m accordingly:
> gfn is guest's view of the BAR and mfn is the physical BAR value as set
> up by the PCI bus driver in the hardware domain.
> This way hardware domain sees physical BAR values and guest sees
> emulated ones.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>

If taking the previous patch as given, the patch here looks okay to me.
But since I'm still not really agreeing with what the previous patch
does, both that and this one will need to be judged on by Roger once
he's back. I'm sorry for the therefore resulting further delay.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.