Re: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view

[Oleksandr <olekstysh@xxxxxxxxx>]

On 27.07.22 13:19, Jan Beulich wrote:

Hello Jan


> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> >
> > Take into account guest's BAR view and program its p2m accordingly:
> > gfn is guest's view of the BAR and mfn is the physical BAR value as set
> > up by the PCI bus driver in the hardware domain.
> > This way hardware domain sees physical BAR values and guest sees
> > emulated ones.
> >
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> If taking the previous patch as given, the patch here looks okay to me.
This is a good news, thank you.


> But since I'm still not really agreeing with what the previous patch
> does,
Previous? Sorry, I didn't see any comments given for "[PATCH V7 05/11] 
vpci/header: handle p2m range sets per BAR".
Or do you perhaps mean "[PATCH V7 03/11] vpci/header: implement guest 
BAR register handlers" where you explicitly mentioned concerns?

> both that and this one will need to be judged on by Roger once
> he's back.

Let's wait for Roger's input here as well.


> I'm sorry for the therefore resulting further delay.
no problem


> Jan
--
Regards,

Oleksandr Tyshchenko