[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup()


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 27 Jul 2022 12:41:43 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=abVLJPaXhdvr7TD3QprCKD6PStejJb80/q+pxQSuBV4=; b=Jn4uB0jXFhFI0mj1Gqj50g7fsLRwIAxrJm3Xlfr4mOeC57+6zZQF/kHf0KHWR+Nt89vOJ6Dp0F0FODdQ/IcHIAyFpysI6J1tIZMjH2rNQ0R92PrEPGSYH/rxZ6NH5oi3kZ69GTB9KCReLB1V3KdpVJ7MNwFIEEIGPcKOSoDOztxag1YRtAA63e881q29L947/3tmygpVxqsS9WUOUObdrXCjuuyJI5G6NHd2YOEIdGVEOew2ff5z2ovy5kJuA2iSVcOxw7YWkmRurbRvF+lqZY2oYCxpmnAPI6O4XWEaOm0Vr5Xqmf+RqmSBl2HuPN6mK5pkCboVDn9ZFBFH8PAylw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PF7fg2INjWL+tlmoWK1I8Z/3KMieIP0ebd9HhQjTAzMPQmTF+V/TQAC17YJrs7Zw0CRHcOn04wRzXYrDrV2Hqf7ac6PtyYRBS3EtFP6+1agoPoUNIG1bBVCUSbW6hjImZW3ReIi5SELEd2ezZu7ejkcLu/VOTv2VYM1NUBlDbACgyObyO3ulBtbGusDwnT9VF+6TIGmFY7ul9X2mhJXECW0EYriio9QF/RIifM8l8BCOwgK15KQgXwTAnZ+gf7v7i4lylduAkZWhmunE9Z4SC+yhQ6Q36bnC+Kf5yKpR3WIX5zAnMTEra4jw5HfPvgYW7N9Rb/R//FMfJbWdcFpvRg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Wed, 27 Jul 2022 10:41:54 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Coverity validly points out that the mfn_add() as used was dead code.

Coverity ID: 1507475
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/arch/x86/pv/dom0_build.c
+++ b/xen/arch/x86/pv/dom0_build.c
@@ -130,7 +130,7 @@ static void __init iommu_memory_setup(st
                             IOMMUF_readable | IOMMUF_writable | IOMMUF_preempt,
                             flush_flags)) > 0 )
     {
-        mfn_add(mfn, rc);
+        mfn = mfn_add(mfn, rc);
         nr -= rc;
         /* See comment below. */
         for ( ; rc--; ++page )



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.