[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 27 Jul 2022 18:25:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eQzNJuj920UfW/Be2q487o/iz2aiVXytfzwbZjlyfp0=; b=fjzEGqoN8de9QMUA3dWJOaURu1jjB2/efvKtUIco7wgYIkr5nn290wRzXSsKP+sXcUfFJSryy/M9Bx+IGiIUrYSGQWDvddmIvsv3vQrByW75Kugl11DKDVCx87kkE6hxGEUKJ0AhqKyj9bwuPZgOHDN/mk+w4GGu+WgSxa0rB/+GhXPsgR4p3Xan0JQ8PL0OPS23OvdtjK1DNFXdkNlBjIuFA5js6TccZKHVBwkz7aaAY/0sjMZf7CKmJDcWA4pIiToIhpnRcAYpmls2xxk7eLrm0ubh3k527q7L5jQEasux3wIMhQIi+qOmjs4qEWSaCGhRF0dUWhuwVAD3uFqI6w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mhKFUMJdNqyzgQfaGRYDyJzJERdbeMEKTYDJbQ+MLJHm3zSREI2FmlnrMjry1V6cj940pzP9UTYhjFiQ6PTYcPexdOhFPKa61w1zpvGvDK898/rPBWf3lEoMEi8ykHfzlNjqaOxYlbzIaOiHUxSL5jxGk/4F8Wdd7ATXfhLiR6UEIIYdeZBEhH1X+DVsPyEM1rXodF9vlXLDu+HwR6SlNDBWUt7sh2ZrlAto7rpAybLFwf5CPQ0rdwIE70uSLSSJTPM4jroaWEgv4BDJQ++6uneiWsWEJWPjyMfL4IPUGIVQwRIuTuXuNB+PTMJOJw/CwVnLFbNyKB0cj9wA6w7a3g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>
- Delivery-date: Wed, 27 Jul 2022 18:25:22 +0000
- Ironport-data: A9a23:Vg28T6KsFYyNE266FE+R/ZQlxSXFcZb7ZxGr2PjKsXjdYENSgj0Cm GcaUG3QMveMMGD3eIp2bITjpksFvsTWzoVmT1BlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/3Z90s11BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE5+RXXWIPJL8k8OspQmNw9 uUfJi4LYUXW7w626OrTpuhEoO0GdZOuFqVP/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H12z+mLGQwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPOkmHUoy727gPJtST1ZK0qKue8z+NjnlPImV1QF0EVV3Lu9JFVjWb7AbqzM Xc8+CAjsKwz/0yDVcTmUluzp3vslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQCy Vuhj97vQzt1v9W9VXOY3qeZq3W1Iyd9EIMZTSoNTA9A6d+zpog210jLVow6T/fzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q==
- Ironport-hdrordr: A9a23:KWYU9a7cfiFTD++LWwPXwZGCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+843WBjB8bZYOCAghrmEGgC1/qu/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXerIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonis2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlaQkEyzzYJriJaYfy+Azdk9vfr2rCV+ O85SvICv4Drk85uFvF+CcFlTOQiArGoEWStGNwyUGT3fARAghKSvapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jRiuCQlGc1sRKEkjTVo+a07bWvHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TpE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZeo6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z44HSKyGG4fIyQZ0Wc9igF3ekJhlTVfsuZDQSTDFYzjsCnv/ITRsXGRv fbAuMiP8Pe
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYoQm4BqyiOS+zvEeDI26X0DRJza2SikyA
- Thread-topic: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush
On 26/07/2022 17:06, Jan Beulich wrote:
> While "type" can include PGT_pae_xen_l2, "x" can't, as the bit is
> cleared upon de-validation (see also the respective assertion earlier in
> the function).
While this statement is true, it doesn't really explain why this is
relevant (or not) to TLB flushing.
As far as the change goes, it's safe on 64bit builds of Xen (I think),
but would not be on 32bit builds when this logic was first written.
~Andrew
|
