[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 28 Jul 2022 08:16:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ctjXa7nPPm7otd0pZFWiekKrS2ikQDzfOS4K/XiAfPA=; b=UT1Gvse1jyX6h9y89S0JkvaL0mRuSJJ4+zF5xOIf3qGU3FfvK4kDlkEYJEuXSa9VK0pJyl+P6wGqAMNaBDAPxM0B/iAYPhm5/BaQv2EkATSf3CxTgt/umndO0WyWxdHHfzVN7BS/mc1bN/7ZvxqxROzo5KQnXH7Vrdxe8/tSydAtvlqPwgO1n1aUhM6eJgedeMc/LN93RxAklZjJB+KW3bZw72G3FnKTtbjORrsJBJGaniwy5Fcx8AvBPxvLYXl1/ahO4PUvKc705fp5soc+LYJFl8jToTJNggMJ1KkaRDUU76Bzz5TI1kPWEHVmUl4+ku3yEPtPVa6NVqNM07voZA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f/UGEfhOIAmqeKv8/xgq6g2rquqVr6vGvR1scdJBFDipYl87iGn55cyHDC6KuUSeG93WI/i6OykILMB1kE7igWgoimsO2GE3IxEriVhzTgvcclk/uATWDdDgGvXDuyDUEUsea1AcTYwAk+8g60EeVEB+qraYIIDK73+cq5cF1gN46Neo3nfS1oLzkH05CWfYwTT3jnc/GjsjRV3FPqtTYyFN25t9YomepUnYsZtiYaQAfSjZ13tuhnIR4/GNJDhnKz+2BhbrU6rXOtXxadYml2UR3kKlh75fZIIxz2jGGYRiNMcGpAKEmYabKIm7B3+Ky/c9IOwQhSrUDZm+YoCZHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 28 Jul 2022 06:18:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.07.2022 20:25, Andrew Cooper wrote:
> On 26/07/2022 17:06, Jan Beulich wrote:
>> While "type" can include PGT_pae_xen_l2, "x" can't, as the bit is
>> cleared upon de-validation (see also the respective assertion earlier in
>> the function).
>
> While this statement is true, it doesn't really explain why this is
> relevant (or not) to TLB flushing.
>
> As far as the change goes, it's safe on 64bit builds of Xen (I think),
> but would not be on 32bit builds when this logic was first written.
How that? The flush is needed if the type changes. If (for the purposes
here) PGT_pae_xen_l2 was considered part of the type, then the bit being
lost upon de-validation would mean we're flushing too little.
Jan
|
