[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/char: imx-lpuart: Fix MISRA C 2012 Rule 20.7 violation
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 2 Aug 2022 13:58:50 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ykHvslcbLjhvOfik3wfqAtqR9v6yDseQUZNGdFn02SE=; b=ntsrrzAHICYv3AcQHGaI/dNbTZc9EgqnfJkAfe48wafKwVEFxyZdxhG5r7GkPYJV4lFge28WCTXGHB5J2fNIAF2b424frcjUuLA8cuChov9MjwIZOg6y816ubgNskZP9ldBEoq6eTn92eQSRl5gYIeWnD1LZCjzymrUqSHpr9WAkAdw1pqt46aVT0rEDOHE8TmXL3TYJJPtQcWFZSAA1uQnk3lhmmcoKQUGeQDyinGl1wj4Id461TKJDgy2djANIyjxvBwA+fJ9EJxUPXk32po5cIiNF4AU9P5gmrDXCvz3ZY4GYGRh2hsSmW76UDYVf4MwExpJMD0bAIay+CB9LgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Erdpbjagjm7TVtT8Lk2R5W/usd/9ghGFtyDJSlrFIrNkoH5yO7fxoK6z5sKdYMLdrdMQeMYqxd6j5sGIORY7tHNZIbGm5WxmDf+mBciv3kz+6jRHTxkch+4tITl24fbgX3+dH17aPfA7HyeYm+NND9DsLpASkDwZn5yScyV0MHVHIYp1BnyPVNDYPiFET8MtvuD3NM9zbU521es5cAs9nFC6UUNsfUZ19tvyw9gn8ATf4nxb9+kybPbztRPStvShBPsf26bvSPehpLir1VpFbISZoAmTm1eZeiUZP0SM629VNdbywFLcg8BnVWQZiDzFlypiEqfTt644GCfqRBNPrw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 02 Aug 2022 11:59:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.08.2022 09:54, Xenia Ragiadakou wrote:
> --- a/xen/drivers/char/imx-lpuart.c
> +++ b/xen/drivers/char/imx-lpuart.c
> @@ -26,8 +26,8 @@
> #include <asm/imx-lpuart.h>
> #include <asm/io.h>
>
> -#define imx_lpuart_read(uart, off) readl((uart)->regs + off)
> -#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + off)
> +#define imx_lpuart_read(uart, off) readl((uart)->regs + (off))
> +#define imx_lpuart_write(uart, off, val) writel((val), (uart)->regs + (off))
As elsewhere before I think at the same time you want to drop the
parentheses from the single use of "val".
Jan
|
