Re: [OSSTEST PATCH 1/2] TestSupport: Add support for installing from backport repo

[Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>]

Anthony PERARD writes ("[OSSTEST PATCH 1/2] TestSupport: Add support for 
installing from backport repo"):
> We are going to need to install package from the debian backport
> repository in order to do a build.

LGTM.  I was kind of surprised we didn't have this already, but now I
come to think of it, I think that was only for kernels ?  (I haven't
UTSL to check.)

> +sub target_install_packages_backport ($@) {
> +    my ($ho, @packages) = @_;
> +    my $had_backport_repo = 0;
> +    target_editfile_root($ho, '/etc/apt/sources.list', sub {
> +        my $suite = $ho->{Suite};
> +        my $bp_url = Osstest::Debian::debian_mirror_url($ho);
> +        while (<::EI>) {
> +            if (m/^# $suite backports/) {
> +                $had_backport_repo = 1;
> +            }
> +            print ::EO;
> +        }
> +        print ::EO <<EOF unless $had_backport_repo;
> +
> +# $suite backports
> +deb $bp_url $suite-backports main
> +EOF
> +        });

Nit: this last line looks misindented to me.

Regardless,

Acked-by: Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>

Thanks,
Ian.

-- 
Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.