[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools


  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 3 Aug 2022 14:16:52 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bjuRwAuXMI38Cgp2GXFBHQFuZTVfBHZ86LZHZ3OcG7g=; b=cbdjqhslxcBgopLAVCLh7gz7iSe4Ngvt8sf0nK+1cHjfEA3ZT/L83ok2LfX2weJE+911rQPmdozQbsOxhyc42c6VJtjSk25uRL4po6aRYmIa1XKlHqsjjwkdR8JmX8d9xArsRw01eHK87TjsQmyRJRB1IXfdQt+gD0j9eALQDvUK9bWGJWLsrvcklaZhN5ba2QZCE8tMRK6LPBH+wU86Nmn9v2/N6yKbD9IP9zOsNu/pxHZel1zubWNeyPCVxAKz9PwONi5t5EtDYfwBVw9ezMFJL4EvLAEkR75NrBzZ3Dl80wPX31iRmDDz/qSdNBtFOGG2NCOGIrm9AsPrIfpV0A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O69EPwgA3ydv7I1pfODLv+sr3tkXinzMEA/eqOGLNmP3dGvWHSsXVEtT9BMQ/JhxYPgZI7hv2JNIZ3PCbUsPwj8ZxPXsX3pbc1wbuIDSKPfTIvGyHmszaZsa+9dl3/64PoRsJrKjnvMrBRkyXNpHQ+d3hcDCLYDlu9Mvdf2EZVq1NyTWEO5wEublCCst1kSErrs0GZUPR7OfIjfSRNPQr+0K4uL1//VeHb8us+meROCbIHsvrg/881cqG69GQmmfAGsUNJS4ezNN/tDQF+/FQDzeI7ifgVSqo2r3fEiuhBdHSFufAzBxZLIwBJhUPlyi1RZX/WdCDzx7wttnZkiDTw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Bertrand Marquis <bertrand.marquis@xxxxxxx>
  • Delivery-date: Wed, 03 Aug 2022 12:17:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.08.2022 14:10, Julien Grall wrote:
> On 03/08/2022 13:05, Jan Beulich wrote:
>> On 03.08.2022 13:57, Bertrand Marquis wrote:
>>> When calling python tools to convert misra documentation or merge
>>> cppcheck xml files, use $(PYTHON).
>>> While there fix misra document conversion script to be executable.
>>>
>>> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
>>> Fixes: 43aa3f6e72 xen/build: Add cppcheck and cppcheck-html make rules
>>
>> Nit: These two titles would want expressing consistently. If I
>> end up committing this, I'll try to remember to adjust.
> 
> There are actually a few issues with the Fixes tags. From the doc [1] :
>    - the sha1 should be 12 characters (rather than 10)

Oh, I didn't even pay attention to that.

>    - the format should be:
>        Fixes: <comidid> ("Commit title")

Right, this was the adjustment I was meaning to make.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.