[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 3 Aug 2022 12:55:01 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nu8PmLjKmiRku0Kk/7dB2Im4mCKJ76wo9ud2Qrrg42E=; b=P0OhJlXXDjW1+FrC+R39UwEfhp6PYtCfmkHy+yUHYBN4ixHcBGKcuzPVHvxXmeZFLGZPYliP5QrrmI6mhKpi8+UJkoWYvsovc6gERVFPg6+ggX/j4LmBmdsPqf4vBHZI5b/lHKYTbVZ/QKgqS1snM/YqS7JZbO7irn6bjmJhxDuhkaTlwdFoWQY3h6sQ8NC8unm+sJ2WNOWbUjQQ3XM5nGMXAfkE0TK6PLU0Ea4iTvvm0rWN9LTVLke7ZI03s7mNA+Mu90OdOqOWF0zDM4yZbr4T3QNvg46AKxf/C6V4yL74QlerE4fW/gh+0DHf2GYyDWQZcKbF2zmt0GKxLeTWfQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nu8PmLjKmiRku0Kk/7dB2Im4mCKJ76wo9ud2Qrrg42E=; b=QkRg7gHtaNRWdAx+7DZeuatWRl3gV88v4SW6B9JVMNhKykikQNYFSaK162U0ODRfBfi7S6lNcVEtnbcXvQkgHFVyot1gJHyYNICZHU985D6y207RdjgKZfPwl9jTAPmZnTVI/Wf8/N1KuAdxmtWlAb4LqibbKmGj377UrkdD3v5SdqGd9XgCJKbmrTQ945BWJFiNFsqLscAEG/faHf8u/CDJatL9/AWt6cdw0TBExIjn7K1B94ylQdg87P0yX0A04hpn6fw43wAUS4y1nwexfN74bMoqAz1NnMZZQZ32iR3FEUIeziXE4ivTnfHheR+FjLCTf4CcIBXLUjcige6TmA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iOKsd61Gt47Si4vcZfDfsA/ZsUUkLPSYmfTdGqKBW+2A0IqLXP845DvHrnqJK8OZbrKvV+ESZs/1J1j+mOHSLF7qlF0OYQccsFJkrJ3wK2+rF9bGaxgn3KijVMYuo3VfmgW5hpEgs3HUUL1UPBV9gA6Xyo/POqp/NUeMNXwAgkLzI5N1MbEza5J74TtBBKUTrScf3Zf8SxZGIOfMsabxbaurTijxH6HCJl0YVrOWwpQBzCzliXfRSbfobtDcLcoJMuPNH90LBsRPX/JbuWW8jhKiCIHOzCJCWA1zSwgz156RzrCBij+HGV1+03guDTGr3zYuH5JG6b2Hcz7yHAdvyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CrkVoLBm4ybeO/obxpSdyTY9iBAS8YW5Jdu3ozPFeUYDe4HGFsukO7Jr8IlQ7T+7rUpOnp3AMSDZ8muk0OU8vgbiBJIDd1pV+/tBwDyKAJSqsKdCJF0YZI9l3MPNkaPHVMIW0k2EsOX3L0ohP9v7ejMHlMexiGSNtEl73xMSCqeyvV7WQg9zAkExB8luJeQj5oGpeV7H61Chx3vMDCgU8iPROVSTdxWd/R653qjFYLI/cGuda39PGn1w7Czte32vj07Ety2ZrSZtwjS4B0khAQq4wGXzhlNgGm26xguNDYXfBztmLCUnnkX/14gAW46hX1vH+/wvRrGKooRZ5hQP9g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 03 Aug 2022 12:55:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYpzA5Sq+ptI31i02cWAL8jJ4SLa2dFF0AgAABZ4CAAAxXgA==
- Thread-topic: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools
> On 3 Aug 2022, at 13:10, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi,
>
> On 03/08/2022 13:05, Jan Beulich wrote:
>> On 03.08.2022 13:57, Bertrand Marquis wrote:
>>> When calling python tools to convert misra documentation or merge
>>> cppcheck xml files, use $(PYTHON).
>>> While there fix misra document conversion script to be executable.
>>>
>>> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
>>> Fixes: 43aa3f6e72 xen/build: Add cppcheck and cppcheck-html make rules
>> Nit: These two titles would want expressing consistently. If I
>> end up committing this, I'll try to remember to adjust.
>
> There are actually a few issues with the Fixes tags. From the doc [1] :
> - the sha1 should be 12 characters (rather than 10)
> - the format should be:
> Fixes: <comidid> ("Commit title")
You want me to resend and fix that ?
On the 12 chars one, I must admit I used git log —oneline and did not count.
Any particular reason to use 12 instead of the 10 that git log is giving ?
Should we suggest how to get this properly in a simple manner ?
Cheers
Bertrand
>
> Cheers,
>
> [1] docs/process/sending-patches.pandoc
>
> --
> Julien Grall
|
