[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 3 Aug 2022 12:56:09 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G6gR2rmGdCitEDGJC/KOMBzV7rQNxrpk/lEjZupbxIc=; b=lkqdt6+43mA64TU42S6Ifc+stuqkoAHIYA2uMolMwd2X+wj4XBmQzFD8jnPN/pUO7WF4F5Nsm7hXKq7RuujFH+THfUeXJxpAOAj5ujsMwOgmIwCi6XrGPh33Ad7rkAN8DAR29Jxo3p/nLqQZgY6bwJWtlT1tpgPPyqh8/2gDAwADnaCWtuVFi/9Yo5a1xfLnftntBUGBGagmxskPFE0oQ+jnrkvl+NTnjQxboFnUmZTxQ5BUkso9PMWFaJhRlHES9zJ37pSKHE+IEB7DN/9w7uhM9YoA3qOWdT2DHZzt9VkoUH5ZDbF+wY8Qra4GUixFC8jZI2tZmbc0aQbe5zs6Tg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G6gR2rmGdCitEDGJC/KOMBzV7rQNxrpk/lEjZupbxIc=; b=f8EsKmpoyChpGucfIofOudqcFxzKJehdzrqPNuRA35L/CfxrlhpUt3Isqa/EFA3hUrtHXVuboSPnD1bMdzOQThsISJ190wS31nu6AO1N3M9WhoN5WVOdyJ+/8jBQju//yvAEOyBu+uxzCIJK1w//mfDQX3sRKQ3BEz3NUj2pB/4sMsfmoyV0kpQakTGbQiv1RnjTbVblf7gkSo+beI5/Zd41PY8obzKvX7MoSftHmNM6fQm7eFIQ5GxWfoeP1cFDeDsDer+i6UyXKpXXCJfH0QWkPCXNREpkOuChoRSHsWV2DSZ4ZKHPNBQin0KVw/l81zA4I00x1EyKRArXuaiVsQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DZRyLlDqsBksf+0YD4ePcR7YA2ZEiGWD0sqte//2rf6dXxK3ZDw7ZMOkpUNAJM3Jo/pGXZMnmNvQ7QGS1Gm2/oe7SIHxEPW45BYZdShgkM3hQGuVz+335X3CV3rkzERpgjjSKyHFHISPsrUlmxpNRgRHwQk1fsDKh06Rxgpjg3pMj7YiF8huNd1mWW3t9eav14v07WAfnR1KTU49kPQzf1r6o547X9ATgutrE/5M/3qEiOv8Serwcr/KM7ueaOdFA5ZEvFDFpSPtoiLGiREue1jNH1eYILlX+FR3Vsupzo3c9qle4DJQZuFy48SnIVjTGQPajbFP6c2/NPTmfcjYNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQAHJQtyKrG+UxNcfmZKB2AleNO/rsYLrkZUT0Ml4zDMhEepdZnCsI4uwSslCoZWD+Lztogo4WARhSmyfWWO9X5CXjoe7Szj8W1kPEc+fPloOvszSoGlIFT5VWAdEYFlcK9vyHflFHJCSYuq/C8gT49ajMfyHtmc/aGX17iqYSyrlTwUBrinBp0D4cWIOFnkNCA2xh9/Q1y3qMPiq1nNTfiMvXWUEJYPxI/WAtuVmqhb0CTmpzfYKaIzdpx2WqjZxL59UgDJ5Y07As1iz5fgsM47uXxK/cFD5IQCj+Dp720bK8o9w/nHKqHVpnhPuoPCuM8gJ9CAxtgOu5DoLZVnJg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 03 Aug 2022 12:56:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYpzA5Sq+ptI31i02cWAL8jJ4SLa2dFF0AgAABZ4CAAAxXgIAAAFGA
- Thread-topic: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools
> On 3 Aug 2022, at 13:55, Bertrand Marquis <Bertrand.Marquis@xxxxxxx> wrote:
>
>
>
>> On 3 Aug 2022, at 13:10, Julien Grall <julien@xxxxxxx> wrote:
>>
>> Hi,
>>
>> On 03/08/2022 13:05, Jan Beulich wrote:
>>> On 03.08.2022 13:57, Bertrand Marquis wrote:
>>>> When calling python tools to convert misra documentation or merge
>>>> cppcheck xml files, use $(PYTHON).
>>>> While there fix misra document conversion script to be executable.
>>>>
>>>> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
>>>> Fixes: 43aa3f6e72 xen/build: Add cppcheck and cppcheck-html make rules
>>> Nit: These two titles would want expressing consistently. If I
>>> end up committing this, I'll try to remember to adjust.
>>
>> There are actually a few issues with the Fixes tags. From the doc [1] :
>> - the sha1 should be 12 characters (rather than 10)
>> - the format should be:
>> Fixes: <comidid> ("Commit title")
>
> You want me to resend and fix that ?
>
> On the 12 chars one, I must admit I used git log —oneline and did not count.
> Any particular reason to use 12 instead of the 10 that git log is giving ?
> Should we suggest how to get this properly in a simple manner ?
Meaning without changing the git config :-)
Cheers
Bertrand
>
> Cheers
> Bertrand
>
>>
>> Cheers,
>>
>> [1] docs/process/sending-patches.pandoc
>>
>> --
>> Julien Grall
|
