[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 4/4] build: replace get-fields.sh by a perl script
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 3 Aug 2022 16:05:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2aaAn/vaTifdPeQJAAC17OamT0yJzk+EsnTTvvyijwo=; b=g4dBvfv0OfaxiPYVe3yQUDcyBzVa609gyJvNRt0HNXGaEk7dhAHNi2kXdUhChyKq/I1U49EuWFofjyheOvFTXiVe+XBMwbfIxEVJCvUZe78pwKGbQ+GTuwPOCZOoDThXLm6DKzWZvh1+L2UDjxBAgtYYdiNvsvTcCasQ6jJEgd6V+rwT3y1EUOYzxqTGj6l+fR4BWV5bNarPzQTvIJ7auK6D/TZORMuykE+5/+UxV1GmCqG7UFBARIH8MDKMpoD5EsMrKgw3p+ffbvIUOyVQunBFv9yAnXesILSU2iXWTTjTTN0/HnOSyTSyND5eoC1BBfLrJj7ucXDj9A1jiGjiVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fACsgLmpMz5r74tfdz47MZ8nCfN9aNPyH0BqttxkosjSv/UDIjgDn5DxaUxl19RnrKm6NJGyBEz+5KemP0ytjstJbQA4bDA7G0ehjTjmdJDelKxa6LpFS7O/fnf9TmqHDrRiQGifvh0GRyR8zq5sqUR0tHxr3uR8s2j8qZPlWW304hrjDBckVa7S7txYopp0jWiuE73c5+hI/98sUb/a/HwaplwNuz6yIhjtbwPGU6Tldp2FFZA5EGNDhlQ1rGL3B+c6Yn0yU8Ar6Mi5L0HEY7NdKCGeoj7g5eEGYeeTgMKllsmreoCtl6bSH+LswdYpciMbLZnTn3nZ8lIcCdMm6A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 03 Aug 2022 14:05:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.08.2022 15:27, Anthony PERARD wrote:
> On Tue, Jun 14, 2022 at 05:22:48PM +0100, Anthony PERARD wrote:
>> The get-fields.sh which generate all the include/compat/.xlat/*.h
>> headers is quite slow. It takes for example nearly 3 seconds to
>> generate platform.h on a recent machine, or 2.3 seconds for memory.h.
>>
>> Since it's only text processing, rewriting the mix of shell/sed/python
>> into a single perl script make the generation of those file a lot
>> faster.
>>
>> I tried to keep a similar look for the code, to keep the code similar
>> between the shell and perl, and to ease review. So some code in perl
>> might look weird or could be written better.
>>
>> No functional change, the headers generated are identical.
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> This patch have been on the mailing list for a little while now, could
> it be acked then committed along with the previous one now?
Well, I would certainly be happy to ack it, but only on the basis of a
suitable R-b by somebody else. My Perl is close to non-existing, so I
can't sensibly review this myself.
Jan
|
