[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2 4/4] build: replace get-fields.sh by a perl script


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Wed, 3 Aug 2022 14:27:43 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 03 Aug 2022 13:27:59 +0000
  • Ironport-data: A9a23:/zGHX6l72diptj4W89KG16no5mJPLROOEa9N2KgSYm36f7AEGi7AQ0E4bYEwkwOOGx2MN4LxfrTIMZgnwacg/LdXDsLzolLdHvP+ukxq7tvdL1A06r1s82kWjEd9aRdn6Ys+0z30HbRw+rWwp/KC+5yskU0JUu22Xkn0ehQnDslHnGbQclqUFdhJJH5DEYwl0qi6g/QeleMLGAEB30/DEamn4qGZlhSK6JZz6qVMTnlTfNcFwUxtqdNlMnLkTLgb3giAy1itS30SmmPwwW9c/tRcsnZBa/1mti1yxeo/7ceS+Eo+lD1kELX3ZyxVjGIUopvutjbxJE7cpBBKjidue6pzlMEUAw6ZE+uoTIEajNNW4ltK79OYQZoGRObdgC8MZ1u6V1FLpkNJcRqDA5crnK/Rtfg6v8hXclXOsAHCHRcqLDFO9AwyXD8wZeLDdUxKAYJOQcS0ctjo+oEiq/99l+EF/n3tzWqOdjBsqdNTdkym+NF6caIQiXEpIg3LgIybUSz/XuZVaOLofR60nLQ9y10R6NwzdXAgpU+s7oUh4QlQYO9pucnKxAMp8OWp1cZgApcfqyD3+TpV9ZUWm+yWOy9+8fvFQM3cdZoDzf243UfwbbqZTmH1ql2HQogISa3M48m1Q5rNQPM6dNXUOQgwQc8jEptPMn+Ge4qzNg68mvmfwfhDPgt9SIxX1t2TRzlMyzPtsanvZpBxuksuUDdmBr255G0HjI51+PSpdpGUKg6UTjAn/4CI31WxUujyJ44KDXJz9w+K5GJ92d3K+jMh1hodJGw8tyxpsmthoIYjDlnIfCxJPngmlKgrEV7pTCYeSOp3t1+g8FwSBtJNe5D7ISbhbNfkl71yp+07IJDv6K3fq+jN6SgtJE1KQSNYTTsDSUaXIlpJ4KSEpJphvnmur7bVWsZM/0obSDxLFPrIHE+5f//tdW4v9sfB1d1O9VQER6zWgyCGYSRB4okXXlu3nOORmLC4ajRcotA9kLQqxgd5OWw9XNpJZ/m1GhrQk+PZwFAUEk/4EIhSVauPvjS4M23PT5cdNWVS/TShIUKccTUlCL642T8wjk7DWo0l4pfWCxh2yGvJZmoDsun43aTHMEDzgGYiC2xCFI+KmJq3ISm1G1pS8BATqeQcB8zkRjd3QV5BDecd8JGfUmzwKJER4XDJbsD8NaCtbupiOkc4ZKirBzbFGAPa+REYgL4Iw56iWnJNnDB2OYA9HYngrITX4jKRl5UexZqaXgzCRKBSOrRwW30QBny3/IderinpEbB/XnlNP43dZjhsjwOkF2yEuZhPfxRLGliQgdvOu1Co7i96u2/JXq7aG172tUO5/snTWYpU65eTy7GJeSyaYC27XLYMlIQtyB+Ur/4wnxydz89ZwYWBIYEzTOc+nA2PsEnn5QdGG990tcAEyvONqvbSplxWK1jGHIApeyGNyt6mXrJ/xyffXr/OorZKIVGxgr6MYKvnJT4p6Lp7gRe+qsNFgCm5dvLHHgqmtEDd1/iGrll0ZoMWxZqiguUNe/Cu7uLqFpbBYslSmxxNkYt7TjOdT2Zs2pi9OmGhlrdFzEdp+JmZX1jFYxeGVKfqvvzp/dK+h7UNi5DSHUn8Ugby8WKbtkRgWtoBxgzX2F+DFYKQb76bF/oaXnzxZQ9gYvhizr/ycXCQOI/oaoijo8CN8FkilvKUmSps+ac85qsFeWvMyHdso1SWhl8Utyg/bqFfGkUECcZzoU5SuDVlD1tSDK5uILrjhV+7AWiKWM4it9POZEWAbfMSD6v0+jB4v/nstZnsQ0plFbxMusPCORvzffn0El5V/xY+SXpEyj7fNDU71BuRwcWRB0x9stLQcfxyeuX9Z2/Vpt4sHikJFBr94wQ60kvFqKvS+zF/kTY+lSUgi+AzU8gFuIf9mPNpBVzypLD/xRg+tWHJtvHoUoM94cH/2cZCvi0cnndLeS5I0lOd+xxSWYkwiSEP9w5/HY0K3JxRHPyANDojh9dcy0VDse6lLcoUNmGt+wQYpmNFFp2G7ONq9pwsiCZTz1CLyhKyC7xirsHF8ws9IGw60Ilx+fiBgla98Evj/PNDaI+VokL3DXZBR2TI/GKO1Ndp4u80DpLiXPRwzjiEV7HBQzmLXw8Ew9p8jp2gEZi+04NeJ6uaJH7gh4HLrwk4FK5+QFrXCC7HLGtaGrkdv9kkfBcCNwmuoDGqjVb2tHsSoR6PymsrPC4KVWIFZgl4e+vgqCdcs06suzsH5TNrFMYqPDff76rkg6Fs7Ks12/wXHgd+e0K6MDbPRXm8U86uW/BH3miaf+uJ5Zv7NjjVW1Mv0oshldbxfHGifPsrXajhBd42VGGosDf581rH6Q7pDS/z5onLg+YSt0l9c+QKSwzrqPtPXU2n8kOwLRmK2/Pf7zBSfOr2/13l1w6+lx8K2zKgTVpt1bOY4ACemAd5LDsaZ1AuC9L8QZp8KAHfttJTJH/M0I9azPcC42t+pD8tb0pIXSXHiVeqBZYptyjJ1Wn7Pw1IBxB/yfekhHDqGL4C0qlHUmr0i22o7Wqb36xmcrdiu8TQtgSOxq4BwmjTV7h2BgQPcqjxy9fMd4FF9pM+gVYHUpb57kM4GvbMdDAigkWgt7ncsrWyPmHdj/i+5zH5RZRxGvoEkvTZQS7vubujAf5ilaamDULyidPGRtsbq+73NkaNRr5YH1vta0WNHMR8c+woeN1Y8osA9Ey2qd35bisPAeOORSne9OP/pfjgKyHn0F9LKcN4GhVvTb/qqazzQoK2xHg2gxhHyq3jzsCL
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jun 14, 2022 at 05:22:48PM +0100, Anthony PERARD wrote:
> The get-fields.sh which generate all the include/compat/.xlat/*.h
> headers is quite slow. It takes for example nearly 3 seconds to
> generate platform.h on a recent machine, or 2.3 seconds for memory.h.
> 
> Since it's only text processing, rewriting the mix of shell/sed/python
> into a single perl script make the generation of those file a lot
> faster.
> 
> I tried to keep a similar look for the code, to keep the code similar
> between the shell and perl, and to ease review. So some code in perl
> might look weird or could be written better.
> 
> No functional change, the headers generated are identical.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Hi,

This patch have been on the mailing list for a little while now, could
it be acked then committed along with the previous one now?

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.