[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 3 Aug 2022 13:29:32 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jFc5BZ+ElYorGtkR3+LTJtv5DFuEoYwMtxGj4hJHeuE=; b=KDzVv7hkAmur+qUJ3qNby3qUeNHedD1497fzUHWG8tbwo3Nn4AFio9uEfM3IBGYm+yZIk28lbKGVkGvIIlbfEpa3zemksOwlNd3cyICoydeX4cLnGy1VkrKKRG6lywHFauy1gkltnCtS4U6H0kbgAHzGh4BfgAuqWwv5MCziw7m07fe8OGoFOI+F4zzold10n4UuNELcv0Gftyn1vfoGmPn+PSsDQbEoYUf4LjebZaGw+HfpO2LcTWQYJB4qBDMMgUo2XZwTSnN6PcM0YqxpZn7nLAPf8lNtdqqUbG49jNM1mH2FwUNXarB8llUi8mJltT6SgAUrdD+wCHSSaSv6RA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jFc5BZ+ElYorGtkR3+LTJtv5DFuEoYwMtxGj4hJHeuE=; b=A9Kbn0nTiqz14i/3PPoD3a25+stNlJyouMh+XDr5SZGQAoTasgHs1zc/D7lmWx+Xbz/IUcL5lWVhZEv39x4Gv96uiANjOfHR/HG2AszNReigjn1KhlgAdiysMepfwNyVMGIL2XnG7xfq8YhOJRdWtTcXHOXSGagb5/z9CUQFigMmixJppKUOziIJoEYNvJcdztj/dgtat+HasiHZIdnM1wzvgl+mct8Uz4isrDXt8NY1+MKifkt/VC7CmyTXukHM7FIz9NqPsF4TFAagzlskaBGNCQb9vwmcNno5vV72OI10Gn8jFqg3FHqirvFXS+kRGr9tSJOEtYUAYPjxlHPRpQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EhARSxh3jdA2uCzzIUNyhxx2g8Mfk9tFSx7x1XhMScchdeh7gEigTVtdfms8tZy+A9tD1o0mZBqlHcOiWQ2aQDteLMZVNmSYZx8toEfm10L+Jyu1ZqjYV/rkwBEUdfkzxk8T1tyiXR6LORAYbTUgSIGBWwTgZPqTv4g4aHspHwdr078Bu3ZEBc+wEdCuz+3X8FtsJ3A7MwW9EdMhqrBAJnlrrIvH7kuzAV4BLPXf/YHX4z5y5vEoqIKZ6EhHA51TrgxYeIiB9r756ouO1/RTKI8cVX80VRPJxMm/acO7A861eA1iyoSRGBjza48GdO8nTI/4W7/uU91twCMVQX+paw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fvr0XP0S2UIAqbsToBFIt4veDdWFhdBHh2/eN+UHUci54MEbkGLEWaAcr4G/q182Bm2VSJtVQrdBxWRfudqZ/32UsErNYtuwjzEvM+MEoMBdHEgJQ7jSPU4GCqRhKTQvdQpsco66gY26Q+am7KLSDMRaGaq/nxpbQSuKteh/wQZIyJr3RkVkWvJb61zYFZJ7E88lSvpxZppFhThDsvmKGOof52GiZ3Wx5YTBdaHZGkHooDRaegG/lHj2430iu0rnwNKhDZYu9THuk86fa/mIJ/UO6UYuUETRjnyrN9ib0ngfgIj/99BLBsYdblqRWsypsK9bZu5x51h6rbwgKI5wbg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 03 Aug 2022 13:30:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYpzA5Sq+ptI31i02cWAL8jJ4SLa2dFF0AgAABZ4CAAAxXgIAAAFGAgAABnYCAAAe3AA==
- Thread-topic: [PATCH v2] tools: use $(PYTHON) to call cppcheck tools
> On 3 Aug 2022, at 14:01, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Bertrand,
>
> On 03/08/2022 13:56, Bertrand Marquis wrote:
>>> On 3 Aug 2022, at 13:55, Bertrand Marquis <Bertrand.Marquis@xxxxxxx> wrote:
>>>
>>>
>>>
>>>> On 3 Aug 2022, at 13:10, Julien Grall <julien@xxxxxxx> wrote:
>>>>
>>>> Hi,
>>>>
>>>> On 03/08/2022 13:05, Jan Beulich wrote:
>>>>> On 03.08.2022 13:57, Bertrand Marquis wrote:
>>>>>> When calling python tools to convert misra documentation or merge
>>>>>> cppcheck xml files, use $(PYTHON).
>>>>>> While there fix misra document conversion script to be executable.
>>>>>>
>>>>>> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
>>>>>> Fixes: 43aa3f6e72 xen/build: Add cppcheck and cppcheck-html make rules
>>>>> Nit: These two titles would want expressing consistently. If I
>>>>> end up committing this, I'll try to remember to adjust.
>>>>
>>>> There are actually a few issues with the Fixes tags. From the doc [1] :
>>>> - the sha1 should be 12 characters (rather than 10)
>>>> - the format should be:
>>>> Fixes: <comidid> ("Commit title")
>>>
>>> You want me to resend and fix that ?
>
> If Jan doesn't want to fix it on commit. Then I would be happy to do it.
Thanks a lot
>
>>>
>>> On the 12 chars one, I must admit I used git log —oneline and did not count.
>>> Any particular reason to use 12 instead of the 10 that git log is giving ?
>
> 10 characters will often result to clash. 12 is known to be sufficient and
> also used by Linux.
Ok
>
>>> Should we suggest how to get this properly in a simple manner ?
>> Meaning without changing the git config :-)
>
> You could use
>
> 42sh> git log --abbrev=<N> --abbrev-commit
It might make sense to add this to the doc ?
I am happy to add this if other think it makes sense.
Cheers
Bertrand
>
> where N is the number of characters.
>
> Cheers,
>
> --
> Julien Grall
|
