[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] x86/entry: move .init.text section higher up in the code for readability
- To: Jane Malalane <Jane.Malalane@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 4 Aug 2022 19:36:23 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ozvjxOWCPPviMtlh8ALbzzgkTWgA0s5ztxHpD3BshrA=; b=KvR5i9CCCRVSE+s7a99ZjeZoovnAl2MWsa4StTI9rVf+qbkBy90viFkvDZmOSmcxrc6pROP/diSowePHl2Mv8v4iTLkFvKdTUWllC+Ya/wIG+lrAuCuik5WQJWim1d2Qnb3qmPM63Zkc9bbJGmwwQu6YPLS2jKCX2WWcwYIfh9GebctjA0NuaZtizXDeP221Pc26nxFWI2lasw0qSZxDSyCFyF9xrN35/nO6fbD2lbpZ0D936JmZi509Jk/MFivz4/Coe6d+2ictdWXpvXvmszW4Vy1iDPlBosXkcYuglCLzkHwKa0gbtmG2r1GgPpFZjAr65YR4mG8NVUCRBOyEMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nju6XtSYNndgXxidz0QHNvdQQLqlvf99zDbs+slOH9p2uyCo2mAjSfJssphYbijPCulUZ+p87wA9NLer22dMO5gvJFwABbBNqXQqJrC97Bdi502A2dBG09OCKDTIX80mQijyzFSHeDdUw57ju1uVlULg5NDS8BvALXZM4QwWsClhlv/7y8jPIxiN7h31A1UFOQ8A9aW6IxHaVUpLfm54pjT7GNVtopqQaG2c4a8C4DJvfIPlJc95wbrHxm0cFsIdvS6jdfIZWkKGN2GJFxyjij2YrvKekPUKVuztyAmtOYmWkirXWkifsjd8qSlpRVs5dwavEY4lkG6oRlru8oZ3Ug==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 04 Aug 2022 19:36:54 +0000
- Ironport-data: A9a23:Jkb/0KyjNAzDIGdDSiV6t+cuxyrEfRIJ4+MujC+fZmUNrF6WrkUBx zQWXWGPaf6JYjekKNwkYY+1oUkFu8TcyoRkHlRv+CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Esz5K+aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1qSx8OFJIX2dxsDHpJ0 KICMQgwMx+q0rfeLLKTEoGAh+wFBeyyZcYzny8lyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCSgNWQH8Dp5poJui4TX5CV33KLgL5z+fduSSN8Otk2Zu njH7yLyBRRy2Nm3lmTbry3917OncSXTVds4Kq27x9xTjViR+F5MGCMrelmFrqzs4qK5c5cFQ 6AOwQI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8ywSTC3UATzVBQMc7r8JwTjsvv neWm/v5CDopt6eaIU9x7Z+RpDK2fCQQc2kLYHZdSRNfuoa75oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr/hu+lTOZJv7CV1GU=
- Ironport-hdrordr: A9a23:CYWfK6DUD4ZE8ljlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vcPHmZw ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYqBOZq/911YsKKEK60hmSvt8o862fIs2A
- Thread-topic: [PATCH 3/4] x86/entry: move .init.text section higher up in the code for readability
On 04/08/2022 16:04, Jane Malalane wrote:
Commit message wants to read "so it's not a random piece of non
.text.entry in the middle of .text.entry" or words to this effect.
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
> ---
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> ---
> xen/arch/x86/x86_64/entry.S | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S
> index 26bf2f1941..4ad25d9c90 100644
> --- a/xen/arch/x86/x86_64/entry.S
> +++ b/xen/arch/x86/x86_64/entry.S
> @@ -140,6 +140,15 @@ process_trap:
> call create_bounce_frame
> jmp test_all_events
>
> + .pushsection .init.text, "ax", @progbits
Given that you've (correctly) dropped the .popsection, this should be a
plain .section rather than .pushsection.
Both can be fixed on commit.
~Andrew
|
