[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] x86/entry: move .init.text section higher up in the code for readability
- To: Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 5 Aug 2022 11:29:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ugxw8LhezYCwoJhbYRDo23JGiRd6ZVGAFvSB1KRHK8=; b=a7f+UHQC3GaCQE5D57wBrJWZR86fHLtXEt+GUX/lHfrBg4jPnXJs5rqUVLm+htCoSUAVLn/N3cnCb0JxryE1ohagSZtmpTZWsN8Pf/0RcOVANDFATtO2pbGtDk1EiQmYBKQnRyudtS922nGTlk7+kmtAGYWZL2df11e08PbaxCSHWoK7gTdAuDKvBbN74sjN20DemxJwJzuA8dXqkYOuRVpnlI4QC+NYeo+SIaA1xuewJ4zGpKpqzOt4KEFjLKre+YWQuxrMaPWaQl6Z+cTHCc4X09663sGf3idrLmuoFU7In9Zb4thQJb1JHDnpboqsO5tNTVcuC5vCpN57FcRayw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgFE/tN/E2GGsKgXtt1tyNKA5dZp3XMObmMnqB1Af5gJpqAP61fO+JRuUkJLXY0NBJvmHWkM3KMwfOfRi1lMrW6ofJ2vLPkLTkewsN9DU3/5bvHw3srjFoF5JsbKe+Qt9G9Me8WgcTbviLiLyNS3cCFoG/fMbZucokxMIjdm8tNdGK32u5od/3/nb2yVPuTFwEwAMgpc9u9SPQUyyrWjx22c6ZqESKrzYNnW5rZ6AQugGheb/63ruBpvWxrzGyyzb7aRqy34RXxE4e+x5i7LE9mqxMEo59SrU6hq4tDUxqKwDylUnM/5DloGf6vktJHOO/qhF797puhDi5xPftJW2Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 05 Aug 2022 09:29:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.08.2022 17:04, Jane Malalane wrote:
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
> ---
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> ---
> xen/arch/x86/x86_64/entry.S | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S
> index 26bf2f1941..4ad25d9c90 100644
> --- a/xen/arch/x86/x86_64/entry.S
> +++ b/xen/arch/x86/x86_64/entry.S
> @@ -140,6 +140,15 @@ process_trap:
> call create_bounce_frame
> jmp test_all_events
>
> + .pushsection .init.text, "ax", @progbits
> + ENTRY(early_page_fault)
Why is this line suddenly not unindented anymore (as labels ought to be)?
> + ENDBR64
> + movl $TRAP_page_fault,4(%rsp)
As you're moving this code, may I ask that you add blanks after the comma
here and ...
> + SAVE_ALL
> + movq %rsp,%rdi
... here? Then, with Andrew's comments also taken care of,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
