[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] xen: Port linkage.h from kernel code
- To: Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 5 Aug 2022 11:24:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x0tsA9oUDG1B/nFNR/reYRCnJtOepE8GG2eBO3vppEE=; b=fjy0S9aB0U+xO9LhXzhVze9oT73k0OpryrNlNJQYniGC6EEWBWP90c0hliYlAD1aTOEQGL0aS/5Bjxxalajd0FGkGIqMSxTrvm0fAe7u9EIRkV8rTe02sYLrQujhsvxPL4LR724Xp4MA+ssdUm+0O1fHMZn5vzFBZswEV2LdDuBWMx1hY82CcUcn8YfyuQSVv0agHFD515/EzAnuIQpEaeQ4ZkLKkYNDKJr+ge+glvFW7d6MU4Qr7hIML0mUNBuc1ZfPZlQgs7OkvzEybZbz+EUhhyb18/y6npO3465Y6M85lPlSqKF99CzmWbJ4A4dIBmzqylxHHpxoNM2dcfmznA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mLyZrdlDTRuDtP8DIbQzUyKY43eugLM64X+2nTVz1l8hDCzpa5c0crQA5LH2ckcGImJKloe0kwXCIwUMhFIfTuEQlzxdLLsXIOOHC45fRDQ1ZnxexoPFS6W3dFPDwUT2+ER2bxfxPam0Qu/4ddr5KdIvPzHCTV/TnUrbXvCkDaQYZsghoxtTieo3yBGP7jZG2X6ulMtLKXIIaXTxW5UOfcXUROjvgaWEPTRVyDsHu881K4DsbO3m0tHbHSAjO4w3FU9oS9u9aJyuYB31uc9FJSDkfwKdBKx5CQWlvj30M4fMcJc858+txg5NUuJvo87rZYDHeaZq6AumCmXk9YlxfA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 05 Aug 2022 09:25:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.08.2022 17:04, Jane Malalane wrote:
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
In the title you say "port", but then you don't say what customization
you've done beyond the obvious adjustment of inclusion guard and
adjustment (actually removal) of #include-s. How much customization we
want to do is important here, after all. I notice you did, for example,
add new flavors of SYM_INNER_LABEL, but then you didn't add anything to
use .hidden (which I have queued as a new patch on top of a supposed v2
of "x86: annotate entry points with type and size"). At the same time
you've left in objtool related commentary, when we don't use that tool
(and no-one knows if we ever will).
I'm further not sure I agree with the naming of some of your additions,
as they appear to not really fit with the naming model used elsewhere.
Your additions also look to not always match style used elsewhere in
this file.
You further want to mention what Linux version this was derived from,
to make it easier to determine what incremental changes to port over
subsequently.
Overall I'm not convinced this is a model we want to go with, first
and foremost because the commonly used macro names are too long for
my taste. What's wrong with ENTRY() and ENDPROC() / ENDDATA()?
Jan
|
