[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] xen: Port linkage.h from kernel code
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Tue, 16 Aug 2022 10:16:01 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EK2XNmUVALpfgvKkGoF4lSj8egYU2wJe1cZ+o5AYVLA=; b=MMdtL5Z0AzJ9Jr4P4uwPuV9iKkaBNyG9z5wVooXpKFWBXKV4kLigNq3+guZXeY8zu8WL4XFDQ8Ed/+rNnvxq+Uv0tlVauYdKHKvUSaLzgdONbwYM0EFGt63GhguCiq55U5u+aMESkk/Yj/Z4EoD6r9CWjLRNLxHt2f7rC/QVisdyaoBDdS7AvRS2xTqGHQBgew0fClHF7Vfz7Z6ZIZPgcaZBDtlBWcE0Vr0d+lcVZvIOaNMDTqgZMdufOK/sVrRV03O8N3FqT8+ijfItopu4ljkGtI8HX75+bCytltvpYLXidIvDZz3kpWw0juxZsLs7cfd6dUiuoBwNeIEj06/4BQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P9+qI3AZYtobN7JrqI3htKai6/k2022B3glcTfku5laVHAXNNKLOt5koz2zPqcky9ThWHEmCkrkdddROb8UK3OXE1duP2S90pm1U0ELia8P8BLZx8GTDogO8xOnJFCD5fNqmHGL+BvyFdIcBCF96ObhgfqK4XkicvHtBpiGaLzgvj12sW/AOGvKG6Ogq82FrPuXU/07DuYcLC5EkbTJ7jz8GccTcikwFZFx/7uCNNG0UQF/xw+UsIPWaErn4LNzBbZJT1I+CoWUIFjGSpl3/luu1qU/YWWcRwOTqURy8Qqe2AH0+YHPJbFd/aSJTZbRVq7/tOS4e4PzUdbeBinnE+A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 16 Aug 2022 10:16:16 +0000
- Ironport-data: A9a23:ZhHj9KN88vgKWGDvrR1jlsFynXyQoLVcMsEvi/4bfWQNrUorhWRTy TQZXj+EPa7ZZjP1eopwaoy+9k4Cup6Ax4VnTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMu/vd8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFP87O1MIVkcY7YY+9R4LTANz uUpdRIkO0Xra+KemNpXS8FKr+F6dozHGd1avXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rr5wCCgKVW0q3rMzUYzy0raygE39bHpOd7cfNGiTsRJhEeI4 GnB+gwVBzlKbIPEl2PUqxpAgMfuzCLdCKIJS4GzzaF2hn23z2giBgUvAA7TTf6RzxTWt8hkA 04e9zcqrKMy3Fe2VdS7VBq9yFaGoxodVtx4A+A8rgaXxcL8+B2FD2IJSjpAbt0Ot8IsQzEuk FiTkLvBGjhHoLCTD3WH+d+8vT60fCQYM2IGTSsFVhcepcnuppkpiRDCRcolF7S65uAZAhn1y jGO6SQ72bMaiJdR073hpA+dxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTUKAnRNNlFP8q4DQA=
- Ironport-hdrordr: A9a23:P3aAd6uMBXcCupk5f815029a7skC2oMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTP2ftXrdyRGVxeZZnMbfKlzbambDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjKzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIA/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfoWG0hYczDgNkGmpDs1L8Yqq iIn/7mBbU215rlRBD3nfIq4Xim7N9h0Q6l9bbSuwqfnSWwfkNHNyMGv/MXTvKR0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59ks5Vza/prVFZql/1pwGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlLhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OEDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowFLau3iee/Fm8Kc7gywlGl/NIwgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcfHmZw ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYqBOcTorV7/AaXU+jvacxRyO/Ya2gCkGAgBFX74A=
- Thread-topic: [PATCH 2/4] xen: Port linkage.h from kernel code
On 05/08/2022 10:24, Jan Beulich wrote:
> On 04.08.2022 17:04, Jane Malalane wrote:
>> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
>
> In the title you say "port", but then you don't say what customization
> you've done beyond the obvious adjustment of inclusion guard and
> adjustment (actually removal) of #include-s. How much customization we
> want to do is important here, after all. I notice you did, for example,
> add new flavors of SYM_INNER_LABEL, but then you didn't add anything to
> use .hidden (which I have queued as a new patch on top of a supposed v2
> of "x86: annotate entry points with type and size"). At the same time
> you've left in objtool related commentary, when we don't use that tool
> (and no-one knows if we ever will).
>
> I'm further not sure I agree with the naming of some of your additions,
> as they appear to not really fit with the naming model used elsewhere.
> Your additions also look to not always match style used elsewhere in
> this file.
>
> You further want to mention what Linux version this was derived from,
> to make it easier to determine what incremental changes to port over
> subsequently.
>
> Overall I'm not convinced this is a model we want to go with, first
> and foremost because the commonly used macro names are too long for
> my taste. What's wrong with ENTRY() and ENDPROC() / ENDDATA()?
Hi Jan,
Since I have no particular opinion on this I went through the discussion
that took place before those macros were introduced in Linux. One of the
points made was that PROC was an ambiguous term to use, since C
functions are not actually procedures, at least not all. The other was
that using START/END markers make it easier for a developer to remember
to add the END marker, and eventhough you suggest using ENTRY and not
just PROC as the start marker, START might still be clearer.
I welcome other input.
Thank you for your review,
Jane.
|
