[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] xen/x86: import linkage.h and clean up x86/kexec.S and x86/entry.S
- To: Jane Malalane <Jane.Malalane@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 4 Aug 2022 20:02:11 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DdiSftAs0A6NBJojnPWBw08jWis86DU+6U1iEsGHZb8=; b=Vp2Vr9lELBnacDu7bzRzRNUZCuxWpNaO0Ugo2AUaPvstAm78Tajqbg+0gh0F0iGoHWoOzw+LjmlvnN8PnbjhSbS6SPaLEq48eyCGDoF6xL2SF/9KvG4me7Am4a7B5L5MHI3EMjHrx9uSRkBux90f92OpH1QryoEseoxgpbAtz04jJvaC75g4w0Z1ejqDJMNWUsv/wsokv8SKn1yJwHeiKH8SdDG7klzZRa0rf2NywaeOkA67z8rsasXvWniv1vTdG9Inj4WGRtUugNMPEQFUxqVjaUPh/qZqYn2OEc5WdVrhoPa/E478GPD0Ri/YmNs5sIq06JJuLeXAVtO3kmmhcg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jUeCPRsoNwAa0nbp2SiiyYXqcxnRVsOgtlz5xaIGKEhgxRKecS/V0/N3+vhoJmcIz3pMnNJyFCdVWyHWw02t0JbUVAUQVn76GTMjHyjTymsI6lktaaISRV9KrB+pV1UAHe4Eel1vav4L9BFCdMbY4tJvsg+VxPwMb6okXfLBa72VmRI21Yw80DxwaZinWKuvuXWsMhZOwj9tdJRgumIfayNIgtoyP9hsRc22iMSFSmtLxXDjv4Yb00yC974RXrUe5mWLCODZeMXZBMAJPKg0mJbQxOCfzpP4LI/Ge519wZ/qSFChbPkR62jEIWg1HnRn7LJsbs0Kws0Hr4f87R3K6Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Thu, 04 Aug 2022 20:02:36 +0000
- Ironport-data: A9a23:lD1EHKg9xEHN3WVKvSGkLOCoX17brhtdoGDDuqucmGfUl6Eq9fh2raMqaBAW4JmfHDDZJAv/Lq82MJgkwZfX7JaqyL8jYAfkX/TOL85gU1Cy7A0xgjY0r8sSxWRf0ITB7zEdaeNvC50Cn53/Ehtrln/tyAkFeOY5i4AgjpQLuro2F9DWD/fkLKDTtfWHUC9Opwx5KpUtM8JTWOiEO0XU0D9nRT1Z6ZB5Bzg2CG+C8pA7tC/9GYKWCcg51xkxxm+4HGKmCndDFf2WF/jLaqcwTH8E/UnQypQ7aKYRYqY3eCREaq+LKQCelXemWWdf7Y+4gH6OTYstf48ENhfivHrfrRefOakCT1HYwG8b+ci2lSPhmz/VvkgGyHWr3qZWBDCu8RN2wNnG94G95R6sSD7LDqTJ3RLvkIky7AOus2SKtMuNmWeaERDi/Mes+A9JEl0F/b0Hjb0NsuoDDCp9qz4hK5rjuFE9VMG+2wryZ+mJQFlbgXXLDoNKUsVkNWwvo+KaR1ROrofGzEWOnUk1SMBjstTFL0/NVW3NGhT6QcaFDfQeFBjoabypacz/YtLeL/sHlsOC10buo6n16DTMdrFYq7r8gw9E0uzpq7qA1r2ud8JaqThKnI+/9qxf/e0bVgKxM8mAC+qkkywuec2KYxaZJObTeWY5d/7Cefci5e2yPKNADb8JFxhEYtql+76oZXJAo/JZ4s41FUQ3olJzQ4Al8tMLSMW0CV4a1bs2SNXwb3WG7oasn5kLkbX5g6dAOsbihg3nt+adQ64KHVBXN/RAPj1/zTdrhcrNm0r/FtkiO8AU4ZKRE+IJLZuE1vG8BfrfSo/k2qcBLi/hbhceUjuwakWulr9NieC/HhausfhKFddYofnVBjPwcnbNPNt315nzYkFU4yAi8rNBEYADfwtKu1uk84Jf95ZIKO8qYkyIxE8iuMOs0PP72nVw1XpH8VmGpkexIB7aMP9sSeEzHES1dl4UuX/tK7zuRoO7WUI3KviOvxakvVzCSMweg7PyEjQHk0FFTB8RBOwoYwEsSmLljstd2fYd47BGnS5iUFP1DUzpSMu+7KncgPgCtwDAERMrmou+L7c051BS4N6FFS3599ayEtawRqKFGLpJzJYR96o5A/N5fjucB3kMa94x00UF40na6RdF7xzmmes68S2sDiq3oKKPc0gQyhskggZW3Juvtd1zISm0On0YuMT5e4b0QUaBmLZZMNQhp4V8/g2VSaRakxxCfcVF9yeWrVu6bMyaFSxvCy18P27jJqCA1y3ypKRevbZQcayVJ4Ner0j3jOJTwzyBXDnlTr3s65TVC9HNJLSLou+y/WEiUe/+DNRqqShYps8+Nj5rLg6/RrO3tDDOMxv0OyxkuTq0x0WdFjpbwDJM84ditelrzn4+sJGziR9x1Jqk8xFt7bqKtIu9Ru83s2ZR2U9mo/UVX7G2ssMKNE0YHPYDCCVbo3qMCppLJBwQ4zJsIt9Z++28XX3bwrObu+f+I73InTFKs6o2wTwua25anAZKHIqd9S9as/XU8PdaqZKQrIHcpzS/+gNw7mp/2wRs9xBTrGNyeb7QJhrD/V4+/bRzX9PqPuug7D/P4x2B4J1zgy1MvkOJt/hqQUq3sAp7FC44vSdNA6IuON1EwG36WP5OpJpRqY9UgFYicq41k16dcZdtt95ffwc4arFAPGqP5o40qh/ov4PTxF2w1/1UonT91FQaI/eXE+PVt88wYOgUokwFEFoxun1zYeBYLV3ddIhagOVwF7GAYJ0jGXn5PcyoauBsS6GnhrRdLkKuNX5lnfeC/5AVzGbxlxl7ccEcGAQiHiVK9J60cQlX7rtdN/hpiRgdklhfUpj9kRGWzLgwqliEgBb8O6LJ0zDZ7/hDd/MFW67xC74+jYhjxNpzKO8QhKIRrrzwLzuvRixvhjRpHdnMXRAiCgKZtZsUxWGsVSMy+ClYfL6XdTlicJ73LDefLNWsKEQUeKYqo+WvREQjKbWkKUg+ljcAdfr3q0zM31RWApgqkYJnbXWIYwtKe0u9J89cRjHKhnnKZw19Qcw3D04yFxWZE+maLJRaNysDQzv8tw24Nbje88pE+H039iwczRYm9iOYKMo4s4QBwOUCQrhol/hc720Rfj5EJAGWRSKqZDFJP93WrqzF3K+buBUR/m+xatWEFlzw7yRzYEUJA3fUwXLYNpuSrXFXrPCe2Z/fEYYso9xd56opJ0wLTLSqRP7aLU0RjSEVGPsiChNzKoIJnVvX50rdq/mso0cLXp4l9BiCoy1x5d9T+fmgq2WSKV7e+5RYwLcB1O1oi/h+KVI7mOdRnDpCfNd7efNANZZClQ+mLPml+mVKswq5onFNd5MS1RNJBhtzZnOVVeJCLHkGwwaZ1EeXMlMbyFydEjiPuJwhfxzZYmy6Cng3cMyO3JTNCwKV9j24e/qT1GzhXSNQVUcoyTZ81ShLQYOO4EJgOo2yuVBbfJg3m7hblaOfh0A3d8hZ7hxtdGkMPsAJqKlGKY+X4nkoH7342V4fNf2Kr5Rh2HkDmYj0oIF1HfnywTrlEFGYdVJy8uUYnKbdjE4tUsEY2LAEnwlFgHZjbhP4APtKhMS8x1M0mSCdCmjcthTKYVZflzDuL/S9brSLNipu/CGSzuzL3WYczuzNASPQRFam+Br1HrIq5Z0nbcDAepYkCXfAacIebRS5kBuMky6jSSs+Br2s/x+g8IGllGGyCE0xauvWeBkiEOzo1DZS35W2luS9rr8vMRznL1AL6w3SBMpi5T1EHd9bisIZmgkX2PI4ip9qsYcjEYZ53b3G0hnXavHaRFQjkhKorW0fIr/yFCix7ZnXoOBnExZg67FrEnr1Qg3ftCGfh1FkU439C9MBSqcH5b+CfQxzdsSHXRTdH4wsH8RQ7x/MUL3YvA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYqBOb2BbPALUx806CiYF/B0ilaq2fKgOA
- Thread-topic: [PATCH 0/4] xen/x86: import linkage.h and clean up x86/kexec.S and x86/entry.S
On 04/08/2022 16:04, Jane Malalane wrote:
> Jane Malalane (4):
> x86/kexec: Add the '.L_' prefix to is_* and call_* labels
> xen: Port linkage.h from kernel code
> x86/entry: move .init.text section higher up in the code for
> readability
> x86: Use linkage.h helpers to add tags to symbols
This probably deserves a bit of explanation.
Patch 4 is the first of several bugfixes which have been outstanding
since XSA-297/MDS (I think - pretty sure it was this XSA, but if not
then it was one around that time) where an attempt to patch
restore_all_guest failed in several creative ways.
First, we need ELF metadata so the livepatch build tools can actually do
their jobs.
Second (and in a series to follow) is teaching Xen's livepatch logic
that .text.entry is special and requires mapping in the XPTI pagetables too.
The choice to go with Linux's linkage.h is because it's already a
standard that people working in our area are familiar with, and because
my previous attempts to sort the ELF metadata have been resounding
failures of nitpicking.
My expectation is that over time, we'll move all asm code over to using
these and retire the current ad-hoc macros we have.
This series is all suggested/requested by me, so implicitly acked, but
should have acks from someone else too.
~Andrew
|
