[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 4/4] x86: Use linkage.h helpers to add tags to symbols
- To: Jane Malalane <Jane.Malalane@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 4 Aug 2022 19:46:44 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ISrKlLdXiQA2kiLLtSCtM90vq56l+CLnZE3FJ/nLlg=; b=Kek12yE1CVwDOokMnHLNjT/7NvE1/TIgelYQVxZBx5qBO2GaWn63CcuL5VH0M6Nll8AmJ5UD4hPfC2E2ibD1l0E59K/jNnQyJJ+mG4c6RZdp00fY5t91JzSDwICOJwvR+9sfcQtHAlKjEz+qGUasYVMLSh+gtasc3BvlYazNQi/DtCfwoR7vsQYK3PNIpcEEGConyhx6+PYkeOmLV4FNete0UwWMuw8mF8gz83F3jihAa1nOGb+uow9dA/YYH9xOLK8zmQwX9CjZ+P7xFU6TWdFe9bbZgh+NBnnI58uqbD+AAcK86Gas2JeK9S++Vv70p4GgEky8aICeLAhEGhB9ig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MU/KkJ+Hbmi8dZHz0jTAq9H+VRPPSxnulBohTXQJMRlvINj5sJvIcUwhNvvi0zAAGhHa26g1tzM0Zt0L0X3g3dxOv99gnrBH4IehZgCHoA897y2HmIBes4cuJ5J5uzfT33bFwK0S6uwMCxLv7b2Rr/5SS/Ir4n2UBafEUvFONkk1NmfBA3j7W1m1V0yMKSTM3zMlv6yM+1z3zdvbZXlX6rkS0cma2gnpj93A2MysNW2X0AwsyZQhtRr0tHTa/c2wDLhiQRJZiKeFmI9apgKgydHZ5g0gB2iGYwA7s9V8jnMuJ7/M7S+Xm7v5Nu85QeQlJ7vyQ6+hZrJFm54ZVqT/kg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 04 Aug 2022 19:47:04 +0000
- Ironport-data: A9a23:5aaA0Ku3wE2B4n16k9Uia94wiefnOphVZm8NNMmfNp3fuWXJ3RfKv9dyOEYHL2/6zzbmfIGanswjXVU0zJTzk7SBzRojec7qhvb+7RL1gYIdxS5XJ3PGNWv7ZzsrfDt9QKPOaUvJt6JZesOMIoM2bJys9E065hwSAaSvbdapmleGGDTSZU3YI2VCvJxk0y2doFz3VnmJpPyXs5c5MBKp9iHku2JFGeSMWi8gOI/LgvBdqknHks1S7XOlzcrFphGfGRHsBX+svhHTZlJxg3dzSeAf/5q7QeU0ayowO48O7i9lgukBq4ZYBWzyIg2NVL58my+LQ+kFY1VSdt5E56s/TQM04EMdOlwLyeItHFT98H+LQPg5MQhkvVKNR2YAbfEoZpL/ru/Mt7vXXCcWoVTay+kUTFUfI3s9/YhuIol5Qe94SE83GYQ/VnQml4goWrmyUvtX2QRu0AwVLtblERZSh74lm2U+tAVWwblVy6Am7Nz2Fk7lWwuGyVmo138Dsrl9uzXl7u61fVb2S0jWz+Qa3ectGsClGIF5/CUMx0NQdY6I/iTuHu9W84u2KVt9TCZ9JrGSoIFQMyGH05H5jco1InAyZWWUSe9lEqzNqizpzcbKZ39KkBwA4reMdKh4K1XPH+gpSR44wecJ40ID1bChyCux/6uBtFBz2XbZIGyZr9qIzYGG1gAR47+8d3U8YgKd8JIO30i7Rz/G5aLsK4xabF64b+0fliyLio7zzKzKP+qmXzJ0fd3EWnZk1FuxWMienhsR6Y1e9VBGduhA5tf765/k9KyDjRVAQh7ftzcORFxbHZFzkAhlqltR75iOYQGBfSYV5OVGTy2nEsGha+z+IN47lEiUrJXVjQbSSTti68jmCG0Kgizb5hFyyCpq3TichfAdXD0E7mSmW+ZezLEiktB7d2QOo2Ss60f+ahGgtcZuhcG0SBvFr1C61qSJHBZLMSmSejOmsjkZObZFOVZVP4OhFnIG59vSzWQIppDMvXLfc7dnE0D79vjiWTzpRpRVSmN0SxUwJX8Hl3sD7cBijNtoqBKcN2y7B7MJUEpUCXXpEdMgY+siqOrRaoplnwrvzKg8W7dxcEeQ7eumNxMYyaEM/vrQFC/gTJ3Ro4EkPhGPn1RCVc1Xm6MJ2YiQO93fkze/mLwBk09QdK2nwvRbmAQIfcQf7jxoni8eR4kdqx1BbUIR//Ei6njktGZybNdkX4YcJyZifKRmpDXKa/oen3WeG+Zch3CojhPIvKKsCdCSXUx+HDRhGn8SyietEoMcdnzjJgowsToHHwuLS7koNURo/veV4nEHyRH/oGPue3cGYNNNcId/MnYcd5yo5r10LEhlMFRwXXDmDTadGPuoP/osmIUfT0PQQHPz5aSMqYM8L9lBUO7D6Ex6Nx6mt7xY0CY/xh04ZP7n34VLocJsuP/ojPPwI+KoPL+zepob0KTE8tXH1qsrzL0K97q/zdQXrf6/GkfUEjR0rUjimtAkQy3LPwI3u7hUCxS4lgpPpCv9mTBIi6u4FVVdJsapS9VFaawdLXpKQHtJdEX/kkvS2WreD9TP9v2NybAG6WVps415qmXvCZdGsoMUB9t7wewJ4sR4mGp9kBjfyqPTNVOPk70uS0Mk4M6XLtzFtxwkOYOSEjeY6N0TR1Ek9CnQiGbBgPtYgFfUt+801gbcgszHERLw79nSR4lw2BuDip+ARs2atdHqPPQyssobF5jdy7/abx8keJWIC/GuCE5e/GIOvHgmmFW4Q8M6MvkvjUlfhQWnRvcNSKqc+XcNT1N1Qho+LAfoqQZQDdWoIIdzl5cqcNsLz0+WkFSenJ3siZSG2BvRLlKv0YlJwVSICYpqMVfv4/IHUbrY/GGSMAE4/z8aNCcWs90/tMEW3WF/uR2Y3CPn5ybsDKhEDPdGyYbm+Bkf991lfH/ZpBLu7NAptbBjD+JsmmH0rXZpydSyXx4u77l9mU2qq3RyB+++U/Rkbm8p0I3921/hxazDbhNIkJ/rDUqL2IhCC3lLah/BMLQmPMm+7SqXa6JBeNbZbRPon96a4gf0OjRQKOuUbVj16fjVi9Jqx14ljKcGwVCCzWFrR4BGNMOUHkEKwv23wfgpZXKj+yrhXt4h1Pp2vpURjJfZM9CLGKhsA7V7O2RbiXZ0iUdhp99eJAwAvJeFd/20C2519euZE4AzNLWdjs91Kh6OzryV8Oc43cDrbFxGzh9C9esQnmKihlVZm5OwQvjzW2IWk1zWtOLtYl56eX9BRq1hegyRrlRH7hZCXkLlBgElOAKHe2F9W6li6D4gGRY8+4gBqyO5dLF26W18O9OcIhBdk8gSJJYGBs34JbVLRZ54VtIcGMinTdthWce3n9khH72EUg41eLL0tmMmJOpD3DiWn4pYFg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYqBOXi/4PmB1YgUyL1NBic4sFxK2fJbIA
- Thread-topic: [RFC PATCH 4/4] x86: Use linkage.h helpers to add tags to symbols
On 04/08/2022 16:04, Jane Malalane wrote:
> Clean up x86_64/kexec_reloc.S and x86_64/entry.S.
It would probably help to split the patch into two, because the reloc
changes are not related to the livepatchability fixes in entry.S
> This fixes the livepatching contents of entry.S.
Well - its the first of several bugfixes.
Specifically, we are adding ELF metadata so that the
livepatch-build-tools can actually binary diff changes in this area.
>
> RFC: I'm unsure on where the page_fault symbol should end, i.e. if
> unlike current code handle_exception_saved should be within page_fault
> like handle_exception is or not.
Jan: we've got two examples (page fault, and NMI) which don't form any
reasonable function layout. Both of these are fallthrough into
handle_{ist,}_exception.
I suggested labelling handle_{ist,}_exception as the main symbol, and
keeping {page_fault,nmi} as small stubs, because we want backtraces to
stay the same and not report {page_fault,nmi} for everything.
~Andrew
|
