[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 4/4] x86: Use linkage.h helpers to add tags to symbols
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 5 Aug 2022 11:40:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RQtI/an3OrELNwPmGg3DJboBXFRJixjRkjtOHlz8FZs=; b=dwg2+k1kYYcPzHqZMQWakmY6HTVAqlERuk4BCzdyafE+Ol5cisBgY5Dhaiun6VsmYubk640pOiXhsQnQPHJwVOozKO1PQbBxO73A8DNdCG4J+gN4jonVPIJYFdTwAZH4sYFWtmPB6MlwpP9womWFcR2Zl8N6V8/tffp0HJva7gix+EZQP6mqRrJR7Kp0n5TpckivG/apo2tlGjMD8uUcsmqw1+sMFDWqhXRVstXZrjsvnkK2UExXD2xrD+IwJa1+EAy1k1QkW5ohryS7z4xcowPdzN6zWsnL84KZobKX4KGbFRj/KFW+9lOEbrNGJVe4pEpgp2BF0pp14TrT0tPhxQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hIrMdF494dLDqEnDhO1s28j7kXzmqMP1rOEDYnXgtZgNHpJWS5HW6yo7B9tp/XcFolV7pdRWBCih0MHPU6xNG7yB7yry6Ox09h9cEYzoXH/J9Z456iY6AMGntVGJGjc17WIE2aNPG4uWmkYqTyq/TSTJl9H+E6KcTrNxFdMz7nMCh9VZfzUqueK9rUxrT/QJbTI8DRrBDohBsW4t5GLYwweiiRN7tMb6CVWFPFZUYFX0PdhNJMAhzbVwUirRnuBWpBLPV194CQ6+g0ywm9ETcEN8VV20sps/IGAKHkJSOphjJFbQV7Ru6sbD3KVMTsnuQk9M+//dDkaUKlmmBXeayw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 05 Aug 2022 09:40:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.08.2022 21:46, Andrew Cooper wrote:
> On 04/08/2022 16:04, Jane Malalane wrote:
>> RFC: I'm unsure on where the page_fault symbol should end, i.e. if
>> unlike current code handle_exception_saved should be within page_fault
>> like handle_exception is or not.
>
> Jan: we've got two examples (page fault, and NMI) which don't form any
> reasonable function layout. Both of these are fallthrough into
> handle_{ist,}_exception.
>
> I suggested labelling handle_{ist,}_exception as the main symbol, and
> keeping {page_fault,nmi} as small stubs, because we want backtraces to
> stay the same and not report {page_fault,nmi} for everything.
I.e. the opposite of what the patch currently does. That's fine with me
in principle (sadly there's no STT_THUNK or alike, which might allow
better reflecting the purpose yet still not marking these as STT_FUNC
nor leaving them at STT_NOTYPE), but the small stubs then want an end
annotation, so that their code is covered by some [start,start+size)
pair in the symbol table. IOW I think that as a final result (not
necessarily right after this series) we want all code and data
contributions to be covered by such a range. Which in turn means for
this series that _if_ an area is touched, it should be brought into
that intended shape.
Jan
|
