[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] x86/kexec: Add the '.L_' prefix to is_* and call_* labels
- To: Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 5 Aug 2022 08:26:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=edln0O7neXUIMAg00ykpAOuvx1m68fqZf3HyjeVwMZU=; b=jSaYoGdHWNJABJndRcPYkf5R9mexz7HXKMEFS2TLn6i2V3uwp4o6TKNGvTVXWLCYSpAiTXFBp0ll3PgBmEqI/0FL/VUu5/V/eYIDtFiA3qOOCkCMS6VHMlBW8Co8/8O/a8GPqAaZcRKj7S/PZxLfqweulAhYaHDyyQbBWlRKwNIwyXanHqHwgauKHsHDvuQgJ+I5RnaRourMp32kTuM4QBsZ0i2perqI0MYmypFmDtpwVGSU4skwHBeiNfsXvKyiaNXPMPr6v0U5tAYY4oPq5PZontmeh48GH8S47LIxzsXVO7oOQFIsxyXcu4R10Ys92gyEhMgn05T7qK7KS//wiw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EPamcx3TydxjEf7bey/oHOHOv+NuTJ1bMqLVdf6xyFz/9ododElLIrecu2tMeiZBR6Rld/rMwziJtBU1H2MZ2/2p1+/TGwNw4jdsj6CDfX7dLIvE1dYgYm1qOw8LVQlJGz+YT5HEph4Zc9YRWX/nk7K5SWaOJOkPf9b5bpWFvkdOh+Dforj/gg8Ju8HQ4uWvXkgpe7IbYzPAFjWNvcqPSpDVqANpNt5pjnC5sLPBnA4fO3fHwYRKNZi6nH/IUW6CsTopvoF8begl9wnv81evYtCFTYJaZZSmSWlGeoGQKjhi0Xub1Ytdog1CzhSzHfzy0mVcLKS7We8imbPVD/mCAw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 05 Aug 2022 06:26:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.08.2022 17:04, Jane Malalane wrote:
> These are local symbols and shouldn't be externally visible.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit I have to admit I'm not overly happy with the underscores you
add. I think we use .L not followed by an underscore about everywhere
else, on the basis (afaic) that the L being upper case already makes
prefix and actual name sufficiently separated. But yes, in some more
recent work from Andrew there are a few cases of .L_ ...
Jan
|
